calc() should not take Relative unit in transform-function of setMatrixValue()

third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Index: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
index ad887b340c610805921112b092eee62ed433f95b..8d7b4c46ea9a66981fece3302b8b68325f67296f 100644
--- a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
@@ -107,12 +107,14 @@ bool TransformBuilder::hasRelativeLengths(const CSSValueList& valueList) {
     for (const CSSValue* item : *transformValue) {
       const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(*item);
 
-      // TODO(hs1217.lee) : to prevent relative unit like calc(10px + 1em).
-      // but when calc() not take parameter of ralative unit like calc(1px +1
-      // px),
-      // shoud be return false;
       if (primitiveValue.isCalculated()) {
-        return true;
+        CSSCalcValue* cssCalcValue = primitiveValue.cssCalcValue();
+        CSSPrimitiveValue::UnitType resolvedType =
+            cssCalcValue->expressionNode()->typeWithCalcResolved();
+        if (CSSPrimitiveValue::isRelativeUnit(resolvedType) ||
+            resolvedType == CSSPrimitiveValue::UnitType::Unknown) {

[alancutter (OOO until 2018), 2017/03/20 00:56:19]

Add test coverage for non-px non-relative lengths and using percent lengths.

[Hwanseung Lee, 2017/03/20 14:10:06]

Done.

+          return true;
+        }
       }
 
       if (CSSPrimitiveValue::isRelativeUnit(