calc() should not take Relative unit in transform-function of setMatrixValue()

third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html

Index: third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
index b4f837ab6c40e8ecec1662fd473acb23ec555e3c..b876e691e66e48e4f4f695f249093e05b46c3111 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html
@@ -215,21 +215,18 @@ test(() => {
   assert_matrix_almost_equals(actualMatrix2, expectedMatrix);
 }, "DOMMatrix setMatrix(multiple value)");
 
-// TODO(hs1217.lee) : calc() function take only absolute unit. should be pass this test.
-// but calc() function is not supported not yet.
-// refer to hasRelativeLengths() in TransformBuilder.cpp
-// test(() => {
-//   var actualMatrix1 = new DOMMatrix(matrix2d);
-//   var actualMatrix2 = new DOMMatrix(matrix3d);
-//   var expectedMatrix = new DOMMatrix();
-//   actualMatrix1.setMatrixValue("translateX(calc(10px + 1px))");
-//   assert_true(actualMatrix1.is2D);
-//   actualMatrix2.setMatrixValue("translateX(calc(10px + 1px))");
-//   assert_true(actualMatrix2.is2D);
-//   expectedMatrix.translateSelf(11, 0)
-//   assert_matrix_almost_equals(actualMatrix1, expectedMatrix);
-//   assert_matrix_almost_equals(actualMatrix2, expectedMatrix);
-// }, "DOMMatrix setMatrix(multiple value)");

[alancutter (OOO until 2018), 2017/03/20 00:56:19]

For future reference we should not check in commented out code. Instead this
should have been checked in with failing expectations.

[Hwanseung Lee, 2017/03/20 14:10:06]

actually, failing expectation was existed.
(https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/dom/...).

but following to your guide, i added more failing cases.

+test(() => {
+  var actualMatrix1 = new DOMMatrix(matrix2d);
+  var actualMatrix2 = new DOMMatrix(matrix3d);
+  var expectedMatrix = new DOMMatrix();
+  actualMatrix1.setMatrixValue("translateX(calc(10px + 1px))");
+  assert_true(actualMatrix1.is2D);
+  actualMatrix2.setMatrixValue("translateX(calc(10px + 1px))");
+  assert_true(actualMatrix2.is2D);
+  expectedMatrix.translateSelf(11, 0)
+  assert_matrix_almost_equals(actualMatrix1, expectedMatrix);
+  assert_matrix_almost_equals(actualMatrix2, expectedMatrix);
+}, "DOMMatrix setMatrix(multiple value)");
 
 test(() => {