Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2758103002:
MediaRecoder: add idlharness WPT (Closed)
|
Created:
3 years, 9 months ago by mcasas Modified:
3 years, 9 months ago Reviewers:
Reilly Grant (use Gerrit) CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMediaRecoder: add idlharness WPT
I just found the power-of-idlharness-tests; this CL
uses them for MediaRecorder.
The idl structures are a verbatim copy of
https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index
(Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests)
BUG=702858
Review-Url: https://codereview.chromium.org/2758103002
Cr-Commit-Position: refs/heads/master@{#457991}
Committed: https://chromium.googlesource.com/chromium/src/+/c5e8a6833acfd6095cac921be31953a572aa7d12
Patch Set 1 : #Patch Set 2 : s/media-recorder/mediacapture-record/ folder to follow the spec name (and not the Class name) #
Messages
Total messages: 24 (20 generated)
Description was changed from ========== MediaRecoder: add wpt idlharness tests As said. (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ========== to ========== MediaRecoder: add wpt idlharness tests I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ==========
Description was changed from ========== MediaRecoder: add wpt idlharness tests I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ========== to ========== MediaRecoder: add wpt idlharness tests I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. The idl structures are a verbatim copy of https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ==========
Description was changed from ========== MediaRecoder: add wpt idlharness tests I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. The idl structures are a verbatim copy of https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ========== to ========== MediaRecoder: add idlharness WPT I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. The idl structures are a verbatim copy of https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ==========
Patchset #1 (id:1) has been deleted
mcasas@chromium.org changed reviewers: + reillyg@chromium.org
reillyg@ PTAL (I understand from [1] that the upstream is automatic and is OK to land this test directly in external/wpt) [1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat...
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org Link to the patchset: https://codereview.chromium.org/2758103002/#ps60001 (title: "s/media-recorder/mediacapture-record/ folder to follow the spec name (and not the Class name)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489895077037060,
"parent_rev": "a6da0ff43c8e632794448104f35ea57c819689c1", "commit_rev":
"c5e8a6833acfd6095cac921be31953a572aa7d12"}
Message was sent while issue was closed.
Description was changed from ========== MediaRecoder: add idlharness WPT I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. The idl structures are a verbatim copy of https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 ========== to ========== MediaRecoder: add idlharness WPT I just found the power-of-idlharness-tests; this CL uses them for MediaRecorder. The idl structures are a verbatim copy of https://w3c.github.io/mediacapture-record/MediaRecorder.html#idl-index (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702858 Review-Url: https://codereview.chromium.org/2758103002 Cr-Commit-Position: refs/heads/master@{#457991} Committed: https://chromium.googlesource.com/chromium/src/+/c5e8a6833acfd6095cac921be319... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c5e8a6833acfd6095cac921be319... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
