MD Settings: Strings sweep.

MD Settings: Strings sweep.

Tweak wording for not-found messages in lists, and remove periods from single sentences that are not followed by anything else.
Note that some single-sentence strings in settings_strings.grdp still has periods, because in the UI they're either followed by another sentence or a link.

BUG=649068
Review-Url: https://codereview.chromium.org/2758073002
Cr-Commit-Position: refs/heads/master@{#458222}
Committed: https://chromium.googlesource.com/chromium/src/+/36641a83225cc90dc457dab7f0db405429448ed4

[scottchen, 2017-03-17 23:10:21]

Patchset #2 (id:20001) has been deleted

[scottchen, 2017-03-17 23:11:44]

scottchen@chromium.org changed reviewers:
+ hcarmona@chromium.org

[hcarmona, 2017-03-20 18:19:30]

LGTM w/ a few questions.

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:460: Saved cards will appear here
Should this be "Saved credit cards will appear here"?

We can land this change as is, and get a quick confirmation from UX to make sure
we want to drop the 'credit' from 'credit cards'.

https://codereview.chromium.org/2758073002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(left):

https://codereview.chromium.org/2758073002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1512:
{"searchOkGoogleLearnMore", IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE},
How did you find this string was no longer used?

[scottchen, 2017-03-20 21:54:00]

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:460: Saved cards will appear here
On 2017/03/20 18:19:29, hcarmona wrote:
> Should this be "Saved credit cards will appear here"?
> 
> We can land this change as is, and get a quick confirmation from UX to make
sure
> we want to drop the 'credit' from 'credit cards'.

That appears to be the proposed string based on the bug description. I'll
confirm again with UX first.

https://codereview.chromium.org/2758073002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(left):

https://codereview.chromium.org/2758073002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1512:
{"searchOkGoogleLearnMore", IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE},
On 2017/03/20 18:19:30, hcarmona wrote:
> How did you find this string was no longer used?

I manually checked the usages of every single-sentence string that had a period,
and when I was looking at the OK-google stuff I noticed there was no learn-more
link on the page, so I did a codesearch and couldn't find
searchOkGoogleLearnMore anywhere.

..Now to think of it, I am also the person who removed the Learn More link per
bettes@'s request a few months back :)

[scottchen, 2017-03-20 21:59:30]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:00:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottchen, 2017-03-20 22:49:19]

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:460: Saved cards will appear here
On 2017/03/20 21:54:00, scottchen wrote:
> On 2017/03/20 18:19:29, hcarmona wrote:
> > Should this be "Saved credit cards will appear here"?
> > 
> > We can land this change as is, and get a quick confirmation from UX to make
> sure
> > we want to drop the 'credit' from 'credit cards'.
> 
> That appears to be the proposed string based on the bug description. I'll
> confirm again with UX first.

UX got back to me, "card" is preferred.

[hcarmona, 2017-03-20 22:51:49]

On 2017/03/20 22:49:19, scottchen wrote:
>
https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
> File chrome/app/settings_strings.grdp (right):
> 
>
https://codereview.chromium.org/2758073002/diff/1/chrome/app/settings_strings...
> chrome/app/settings_strings.grdp:460: Saved cards will appear here
> On 2017/03/20 21:54:00, scottchen wrote:
> > On 2017/03/20 18:19:29, hcarmona wrote:
> > > Should this be "Saved credit cards will appear here"?
> > > 
> > > We can land this change as is, and get a quick confirmation from UX to
make
> > sure
> > > we want to drop the 'credit' from 'credit cards'.
> > 
> > That appears to be the proposed string based on the bug description. I'll
> > confirm again with UX first.
> 
> UX got back to me, "card" is preferred.

Cool, thanks for checking :-)

[commit-bot: I haz the power, 2017-03-20 23:07:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490047170740070, "parent_rev":
"63cc3baf66c95477bdf95ebe75a322db342e60e7", "commit_rev":
"36641a83225cc90dc457dab7f0db405429448ed4"}

[commit-bot: I haz the power, 2017-03-20 23:07:49]

Description was changed from

==========
MD Settings: Strings sweep.

Tweak wording for not-found messages in lists, and remove periods from single
sentences that are not followed by anything else.
Note that some single-sentence strings in settings_strings.grdp still has
periods, because in the UI they're either followed by another sentence or a
link.

BUG=649068
==========

to

==========
MD Settings: Strings sweep.

Tweak wording for not-found messages in lists, and remove periods from single
sentences that are not followed by anything else.
Note that some single-sentence strings in settings_strings.grdp still has
periods, because in the UI they're either followed by another sentence or a
link.

BUG=649068

Review-Url: https://codereview.chromium.org/2758073002
Cr-Commit-Position: refs/heads/master@{#458222}
Committed:
https://chromium.googlesource.com/chromium/src/+/36641a83225cc90dc457dab7f0db...
==========

[commit-bot: I haz the power, 2017-03-20 23:07:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36641a83225cc90dc457dab7f0db...