Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2758023002: Enable overlay scrollbars on ChromeOS (Closed)

Created:
3 years, 9 months ago by bokan
Modified:
3 years, 9 months ago
Reviewers:
stgao, Evan Stade
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable overlay scrollbars on ChromeOS BUG=307091 Review-Url: https://codereview.chromium.org/2758023002 Cr-Commit-Position: refs/heads/master@{#458747} Committed: https://chromium.googlesource.com/chromium/src/+/37d6a8ca363156afcd47862c53577d283988382c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/native_theme/native_theme_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
bokan
3 years, 9 months ago (2017-03-17 21:02:36 UTC) #3
Evan Stade
lgtm
3 years, 9 months ago (2017-03-18 00:49:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758023002/1
3 years, 9 months ago (2017-03-22 12:21:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/345334)
3 years, 9 months ago (2017-03-22 13:12:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758023002/1
3 years, 9 months ago (2017-03-22 13:57:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/37d6a8ca363156afcd47862c53577d283988382c
3 years, 9 months ago (2017-03-22 14:51:53 UTC) #16
stgao
This CL seems to make OverflowButtonActiveInkDropTest.TouchDragOutAndBack flaky on "Linux ChromiumOS Ozone Tests (1)". Mind investigating ...
3 years, 9 months ago (2017-03-23 18:04:52 UTC) #18
bokan
On 2017/03/23 18:04:52, stgao(ping after 24h) wrote: > This CL seems to make OverflowButtonActiveInkDropTest.TouchDragOutAndBack flaky ...
3 years, 9 months ago (2017-03-23 18:10:20 UTC) #19
stgao
3 years, 9 months ago (2017-03-23 18:16:28 UTC) #20
Message was sent while issue was closed.
On 2017/03/23 18:10:20, bokan wrote:
> On 2017/03/23 18:04:52, stgao(ping after 24h) wrote:
> > This CL seems to make OverflowButtonActiveInkDropTest.TouchDragOutAndBack
> flaky
> > on "Linux ChromiumOS Ozone Tests (1)". Mind investigating and fixing?
> > 
> >
>
https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWV...
> 
> Of course. Is there a bug tracking the flakiness?

Here it is https://bugs.chromium.org/p/chromium/issues/detail?id=704629

Powered by Google App Engine
This is Rietveld 408576698