[runtime] Add function for printing type profile.

[runtime] Add function for printing type profile.

Separate the function that prints type profile with
--type-profile from the one that collects type profile.

The name needs to be stored in the feedback vector as well. I'll make a
follow up CL that stores the relevant information, so it can
be printed later.

BUG=v8:5935
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2757993002
Cr-Commit-Position: refs/heads/master@{#43929}
Committed: https://chromium.googlesource.com/v8/v8/+/3e0aabb62f0062f238c3778d1a7d1494d32ecaad

[Franzi, 2017-03-17 20:19:34]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 20:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:23:12]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19321)

[Franzi, 2017-03-17 20:26:45]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 20:26:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:53:57]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-03-20 07:13:35]

Description was changed from

==========
[runtime] Runtime function for printing type profile.

Separate the function that prints type profile with
--type-profile from the one that collects type profile.

The name needs to be stored in the feedback vector as well. I'll make a
follow up CL that stores the relevant information, so it can
be printed later.

BUG=v8:5935
R=yangguo@chromium.org
==========

to

==========
[runtime] Add function for printing type profile.

Separate the function that prints type profile with
--type-profile from the one that collects type profile.

The name needs to be stored in the feedback vector as well. I'll make a
follow up CL that stores the relevant information, so it can
be printed later.

BUG=v8:5935
R=yangguo@chromium.org
==========

[Franzi, 2017-03-20 07:14:17]

Ptal

[Yang, 2017-03-20 08:48:45]

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:160: HandleScope scope(isolate);
Let's DCHECK that args.length() is 1.

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:166: if (!function_object->IsJSFunction()) {
You can omit this type check if you define function_object to be JSFunction
above.

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:185: return isolate->heap()->undefined_value();
Do you really want to return after the first TypeProfile slot?

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h#n...
src/runtime/runtime.h:554: F(PrintTypeProfile, -1, 1)                  \
I think you need argument count 1, not -1.

https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
File test/message/type-profile/collect-type-profile.out (left):

https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
test/message/type-profile/collect-type-profile.out:103: number
What happened to the types we collected for my_var2?

[Franzi, 2017-03-20 09:24:34]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 09:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2017-03-20 09:29:34]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 09:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 09:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 09:53:40]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-03-20 10:09:57]

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:160: HandleScope scope(isolate);
On 2017/03/20 08:48:45, Yang wrote:
> Let's DCHECK that args.length() is 1.

Done.

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:166: if (!function_object->IsJSFunction()) {
On 2017/03/20 08:48:45, Yang wrote:
> You can omit this type check if you define function_object to be JSFunction
> above.

Done.

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:185: return isolate->heap()->undefined_value();
On 2017/03/20 08:48:45, Yang wrote:
> Do you really want to return after the first TypeProfile slot?

Yes! Sorry, I discussed offline with Michi that we'll use 1 slot for all type
information.

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h#n...
src/runtime/runtime.h:554: F(PrintTypeProfile, -1, 1)                  \
On 2017/03/20 08:48:45, Yang wrote:
> I think you need argument count 1, not -1.

Done.

https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
File test/message/type-profile/collect-type-profile.out (left):

https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
test/message/type-profile/collect-type-profile.out:103: number
On 2017/03/20 08:48:45, Yang wrote:
> What happened to the types we collected for my_var2?

I turned off type profile for assignments for now, because it convolutes the
output and I'll move everything to one slot and need a different data structure
and Print() function in the nexus anyways.

[Yang, 2017-03-20 11:40:15]

On 2017/03/20 10:09:57, Franzi wrote:
>
https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
> File src/runtime/runtime-test.cc (right):
> 
>
https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
> src/runtime/runtime-test.cc:160: HandleScope scope(isolate);
> On 2017/03/20 08:48:45, Yang wrote:
> > Let's DCHECK that args.length() is 1.
> 
> Done.
> 
>
https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
> src/runtime/runtime-test.cc:166: if (!function_object->IsJSFunction()) {
> On 2017/03/20 08:48:45, Yang wrote:
> > You can omit this type check if you define function_object to be JSFunction
> > above.
> 
> Done.
> 
>
https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime-tes...
> src/runtime/runtime-test.cc:185: return isolate->heap()->undefined_value();
> On 2017/03/20 08:48:45, Yang wrote:
> > Do you really want to return after the first TypeProfile slot?
> 
> Yes! Sorry, I discussed offline with Michi that we'll use 1 slot for all type
> information.
> 
> https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h
> File src/runtime/runtime.h (right):
> 
>
https://codereview.chromium.org/2757993002/diff/20001/src/runtime/runtime.h#n...
> src/runtime/runtime.h:554: F(PrintTypeProfile, -1, 1)                  \
> On 2017/03/20 08:48:45, Yang wrote:
> > I think you need argument count 1, not -1.
> 
> Done.
> 
>
https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
> File test/message/type-profile/collect-type-profile.out (left):
> 
>
https://codereview.chromium.org/2757993002/diff/20001/test/message/type-profi...
> test/message/type-profile/collect-type-profile.out:103: number
> On 2017/03/20 08:48:45, Yang wrote:
> > What happened to the types we collected for my_var2?
> 
> I turned off type profile for assignments for now, because it convolutes the
> output and I'll move everything to one slot and need a different data
structure
> and Print() function in the nexus anyways.

lgtm

[Franzi, 2017-03-20 12:06:49]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2017-03-20 12:07:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 12:10:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490011609867940,
"parent_rev": "ab97fd76effb4c2075b35f61a7806311c21a5bea", "commit_rev":
"3e0aabb62f0062f238c3778d1a7d1494d32ecaad"}

[commit-bot: I haz the power, 2017-03-20 12:10:20]

Description was changed from

==========
[runtime] Add function for printing type profile.

Separate the function that prints type profile with
--type-profile from the one that collects type profile.

The name needs to be stored in the feedback vector as well. I'll make a
follow up CL that stores the relevant information, so it can
be printed later.

BUG=v8:5935
R=yangguo@chromium.org
==========

to

==========
[runtime] Add function for printing type profile.

Separate the function that prints type profile with
--type-profile from the one that collects type profile.

The name needs to be stored in the feedback vector as well. I'll make a
follow up CL that stores the relevant information, so it can
be printed later.

BUG=v8:5935
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2757993002
Cr-Commit-Position: refs/heads/master@{#43929}
Committed:
https://chromium.googlesource.com/v8/v8/+/3e0aabb62f0062f238c3778d1a7d1494d32...
==========

[commit-bot: I haz the power, 2017-03-20 12:10:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/3e0aabb62f0062f238c3778d1a7d1494d32...