Update CBD dialog and Site Settings secondary strings in MD settings

Update CBD dialog and Site Settings secondary strings in MD settings

The "Site settings" secondary string:
  - Swapped the two parts to mention "information" first and "content"
    second, as the former is more important from the privacy perspective
  - Removed "as you browse", as the string was already very long and
    this didn't add additional value; in fact, it could have been
    interpreted that the settings are per browsing session
  - We considered adding a few examples of the most important site
    settings (cookies, plugins, microphone), but this is not possible
    due to spatial constraints

The "Clear Browsing Data" secondary string:
  - The old secondary string "Control your browsing data" said *less*
    than the primary "Clear Browsing Data"
  - We replaced it with examples of browsing data, same as we do in
    Android settings

BUG=595580
Review-Url: https://codereview.chromium.org/2757963002
Cr-Commit-Position: refs/heads/master@{#459029}
Committed: https://chromium.googlesource.com/chromium/src/+/a8e6ee4111187f847c2aa29b8d4afed3a888a012

[msramek, 2017-03-17 19:53:59]

msramek@chromium.org changed reviewers:
+ maxwalker@chromium.org, srahim@chromium.org

[msramek, 2017-03-17 19:53:59]

Hi Max and Shimi,

Please have a look! I discussed these two string updates with Max today, see the
rationale in the CL description. We tried to get the word "permissions" into the
"site settings" string, but didn't manage to; but I think it's an improvement
anyway.

Thanks,
Martin

[srahim, 2017-03-17 23:26:08]

Suggestions for what things we call out in the Clear Browsing Data secondary
text, and for clarifying a message description.

https://codereview.chromium.org/2757963002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2757963002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1616: Control what information websites can use
and what content they can show you
LGTM

https://codereview.chromium.org/2757963002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1621: <message
name="IDS_SETTINGS_CLEAR_DATA_DESCRIPTION" desc="Description for clear browsing
data button in Privacy options">
Add to message description: "History" refers to browsing history. "Cookies"
refers to the technical meaning of a cookie, i.e. data sent from a website and
stored on the user's computer, as in when a website saves your username or
password.

https://codereview.chromium.org/2757963002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1622: Clear history, cookies, site data, cache…
Could we not use "cache" which isn't a very user-friendly word? Also I don't
think most users will know what "site data" is.

Some options:
A. If you want to list +2 things:
Clear history, cookies, images and files, and more

B. If you don't want to call out "images" for fear of users clearing images for
the wrong reasons:
Clear history, cookies, and more

[maxwalker, 2017-03-20 10:45:10]

Thanks, Shimi! Leaving out "site data" is a great idea.

I think "cache" is equivalent to "cookies": it's a rather technical term, but
very common and hard to describe in simpler words.
It would be good to be consistent with the items and order we have in the CBD
dialog (https://goo.gl/c9Rk9y).

So I would suggest C:
Clear history, cookies, cache, and more

Preview: https://screenshot.googleplex.com/3p4ur8JLKrx.png.
WDYT?

[srahim, 2017-03-21 17:32:24]

On 2017/03/20 10:45:10, maxwalker wrote:
> Thanks, Shimi! Leaving out "site data" is a great idea.
> 
> I think "cache" is equivalent to "cookies": it's a rather technical term, but
> very common and hard to describe in simpler words.
> It would be good to be consistent with the items and order we have in the CBD
> dialog (https://goo.gl/c9Rk9y).
> 
> So I would suggest C:
> Clear history, cookies, cache, and more
> 
> Preview: https://screenshot.googleplex.com/3p4ur8JLKrx.png.
> WDYT?

"Clear history, cookies, cache, and more" SGTM. Thanks!

[msramek, 2017-03-22 13:55:08]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:55:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-03-22 13:59:04]

Thanks both!

I updated the string and the description.

I changed the description a bit to emphasize that "cookies" are what is *saved*
by the website (since all sorts of data are sent and saved, but "cookies and
site data" is what the website chooses to save) and to mention "preferences"
instead of "username and password" (saving passwords in cookies would be a great
security risk).

Shimi, please let me know if there's anything else you want to tweak.

[msramek, 2017-03-22 14:00:05]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org

[msramek, 2017-03-22 14:00:05]

Otherwise, +Dan, can you please rubberstamp?

These are the two strings that were mentioned in our meeting last week; UX folks
have already reviewed them.

[commit-bot: I haz the power, 2017-03-22 14:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:04:50]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-03-22 20:40:26]

lgtm

[msramek, 2017-03-23 09:17:24]

Thanks!

[msramek, 2017-03-23 09:17:28]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-03-23 09:17:29]

The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org
Link to the patchset: https://codereview.chromium.org/2757963002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-03-23 09:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 09:21:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490260648441060,
"parent_rev": "9a17ccc9dee66e65bef17be5a0d6fe6c5ee79767", "commit_rev":
"a8e6ee4111187f847c2aa29b8d4afed3a888a012"}

[commit-bot: I haz the power, 2017-03-23 09:22:24]

Description was changed from

==========
Update CBD dialog and Site Settings secondary strings in MD settings

The "Site settings" secondary string:
  - Swapped the two parts to mention "information" first and "content"
    second, as the former is more important from the privacy perspective
  - Removed "as you browse", as the string was already very long and
    this didn't add additional value; in fact, it could have been
    interpreted that the settings are per browsing session
  - We considered adding a few examples of the most important site
    settings (cookies, plugins, microphone), but this is not possible
    due to spatial constraints

The "Clear Browsing Data" secondary string:
  - The old secondary string "Control your browsing data" said *less*
    than the primary "Clear Browsing Data"
  - We replaced it with examples of browsing data, same as we do in
    Android settings

BUG=595580
==========

to

==========
Update CBD dialog and Site Settings secondary strings in MD settings

The "Site settings" secondary string:
  - Swapped the two parts to mention "information" first and "content"
    second, as the former is more important from the privacy perspective
  - Removed "as you browse", as the string was already very long and
    this didn't add additional value; in fact, it could have been
    interpreted that the settings are per browsing session
  - We considered adding a few examples of the most important site
    settings (cookies, plugins, microphone), but this is not possible
    due to spatial constraints

The "Clear Browsing Data" secondary string:
  - The old secondary string "Control your browsing data" said *less*
    than the primary "Clear Browsing Data"
  - We replaced it with examples of browsing data, same as we do in
    Android settings

BUG=595580

Review-Url: https://codereview.chromium.org/2757963002
Cr-Commit-Position: refs/heads/master@{#459029}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8e6ee4111187f847c2aa29b8d4a...
==========

[commit-bot: I haz the power, 2017-03-23 09:22:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8e6ee4111187f847c2aa29b8d4a...