Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2757933002: Allow building non-Android with enable_webvr (Closed)

Created:
3 years, 9 months ago by billorr
Modified:
3 years, 9 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, asvitkine+watch_chromium.org, cjgrant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow building non-Android with enable_webvr This change prevents bringing in Android-specific code when enable_webvr build flag is set. BUG=702701 Review-Url: https://codereview.chromium.org/2757933002 Cr-Commit-Position: refs/heads/master@{#457897} Committed: https://chromium.googlesource.com/chromium/src/+/94d3a79f9203c370a83dc3d71441b513763be7c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
billorr
PTAL
3 years, 9 months ago (2017-03-17 19:34:42 UTC) #6
mthiesse
lgtm, though I don't own any of those files.
3 years, 9 months ago (2017-03-17 19:46:13 UTC) #7
billorr
On 2017/03/17 19:46:13, mthiesse wrote: > lgtm, though I don't own any of those files. ...
3 years, 9 months ago (2017-03-17 19:50:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757933002/1
3 years, 9 months ago (2017-03-17 19:51:00 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 22:47:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94d3a79f9203c370a83dc3d71441...

Powered by Google App Engine
This is Rietveld 408576698