|
Move StoragePartitionHttpCacheDataRemover to content/
StoragePartitionHttpCacheDataRemover is used to delete the contents of a cache
obtained from a given StoragePartition. There are three callsites:
BrowsingDataRemover (which will soon move to content/), CacheCounter (chrome/)
and WebViewGuest (in extensions/).
The original plan was that StoragePartitionHttpCacheDataRemover would move
to content together with BrowsingDataRemover, and the latter two callsites
would then request cache deletion using a DATA_TYPE_CACHE request
to BrowsingDataRemover rather than StoragePartitionHttpCacheDataRemover.
However, this is not possible, as WebViewGuest requests a deletion for
a particular non-default StoragePartition (unlike BrowsingDataRemover, which
uses BrowserContext::GetDefaultStoragePartition()).
Therefore, we move StoragePartitionHttpCacheDataRemover to content/ first
and expose it in the content/public interface through
StoragePartition::ClearHttpAndMediaCaches(). Together with it, we move the
ConditionalCacheDeletionHelper class (which is only used by the former
for conditional deletions and can eventually be folded into it).
Additionally, we move the class' browsertest which also necessitates the move
of CacheTestUtil to content/public/test. This can be eventually folded into
BrowsingDataRemover's test utils once BrowsingDataRemover into content/,
since browsing_data/ tests are the only users of these utils.
BUG= 668114
Review-Url: https://codereview.chromium.org/2757923002
Cr-Commit-Position: refs/heads/master@{#459851}
Committed: https://chromium.googlesource.com/chromium/src/+/ee2be6e582be6b73f96eb7caf150e57fb1817dc4
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+138 lines, -977 lines) |
Patch |
|
M |
chrome/browser/browsing_data/browsing_data_remover_impl.cc
|
View
|
1
2
3
|
3 chunks |
+13 lines, -22 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
|
View
|
1
2
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browsing_data/cache_counter_browsertest.cc
|
View
|
1
2
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
D |
chrome/browser/browsing_data/cache_test_util.h
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
|
D |
chrome/browser/browsing_data/cache_test_util.cc
|
View
|
|
1 chunk |
+0 lines, -147 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
D |
chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -180 lines |
0 comments
|
Download
|
|
M |
chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/test/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/browsing_data/content/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
D |
components/browsing_data/content/conditional_cache_deletion_helper.h
|
View
|
|
1 chunk |
+0 lines, -73 lines |
0 comments
|
Download
|
|
D |
components/browsing_data/content/conditional_cache_deletion_helper.cc
|
View
|
|
1 chunk |
+0 lines, -96 lines |
0 comments
|
Download
|
|
D |
components/browsing_data/content/storage_partition_http_cache_data_remover.h
|
View
|
|
1 chunk |
+0 lines, -101 lines |
0 comments
|
Download
|
|
D |
components/browsing_data/content/storage_partition_http_cache_data_remover.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -201 lines |
0 comments
|
Download
|
|
M |
content/browser/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A + |
content/browser/browsing_data/conditional_cache_deletion_helper.h
|
View
|
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
A + |
content/browser/browsing_data/conditional_cache_deletion_helper.cc
|
View
|
1
|
5 chunks |
+13 lines, -16 lines |
0 comments
|
Download
|
|
A + |
content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
|
View
|
1
|
5 chunks |
+12 lines, -13 lines |
0 comments
|
Download
|
|
A + |
content/browser/browsing_data/storage_partition_http_cache_data_remover.h
|
View
|
1
2
|
4 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
A + |
content/browser/browsing_data/storage_partition_http_cache_data_remover.cc
|
View
|
1
2
3
|
7 chunks |
+20 lines, -25 lines |
0 comments
|
Download
|
|
M |
content/browser/storage_partition_impl.h
|
View
|
1
2
3
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/storage_partition_impl.cc
|
View
|
1
2
3
|
2 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/browser/storage_partition.h
|
View
|
1
2
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
A + |
content/public/test/cache_test_util.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
A + |
content/public/test/cache_test_util.cc
|
View
|
1
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/test/BUILD.gn
|
View
|
1
2
3
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
extensions/browser/guest_view/web_view/web_view_guest.cc
|
View
|
1
2
|
2 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
Total messages: 28 (17 generated)
|