Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2757833003: Disabling flaky piece of WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings on Mac. (Closed)

Created:
3 years, 9 months ago by Henrik Grunell
Modified:
3 years, 9 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, jam, darin-cc_chromium.org, sakal-chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky piece of WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings on Mac. BUG=700859 TBR=guidou@chromium.org Review-Url: https://codereview.chromium.org/2757833003 Cr-Commit-Position: refs/heads/master@{#457722} Committed: https://chromium.googlesource.com/chromium/src/+/49e5417df55af98a03d4a055755fdf05ec093d7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Henrik Grunell
3 years, 9 months ago (2017-03-17 08:28:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757833003/1
3 years, 9 months ago (2017-03-17 08:28:23 UTC) #5
Guido Urdaneta
lgtm
3 years, 9 months ago (2017-03-17 08:58:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/49e5417df55af98a03d4a055755fdf05ec093d7c
3 years, 9 months ago (2017-03-17 09:08:46 UTC) #9
Henrik Grunell
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2764953003/ by grunell@chromium.org. ...
3 years, 9 months ago (2017-03-22 09:30:02 UTC) #10
Henrik Grunell
3 years, 9 months ago (2017-03-22 09:50:24 UTC) #11
Message was sent while issue was closed.
On 2017/03/22 09:30:02, Henrik Grunell wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2764953003/ by mailto:grunell@chromium.org.
> 
> The reason for reverting is: Speculatively re-enabing: the flakiness could
have
> been fixed by
>
https://chromium.googlesource.com/chromium/src/+/558e1295655666d3e80365af85de....

New CL for re-enabling: https://codereview.chromium.org/2768623003/

Powered by Google App Engine
This is Rietveld 408576698