Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2757833002: Deprecate Extensions.InjectScriptTime histogram (Closed)

Created:
3 years, 9 months ago by Kunihiko Sakamoto
Modified:
3 years, 9 months ago
Reviewers:
Devlin, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate Extensions.InjectScriptTime histogram This histogram isn't useful when content scripts are injected asynchronously, as this measures the time taken to just post a task. BUG=636655 Review-Url: https://codereview.chromium.org/2757833002 Cr-Commit-Position: refs/heads/master@{#458288} Committed: https://chromium.googlesource.com/chromium/src/+/3b3e4fe434fa1165715fe60b49b4b642879cca90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M extensions/renderer/script_injection.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Kunihiko Sakamoto
This is a follow-up to http://crrev.com/2633253002.
3 years, 9 months ago (2017-03-17 10:05:59 UTC) #7
Devlin
lgtm, thanks!
3 years, 9 months ago (2017-03-17 15:17:26 UTC) #8
Ilya Sherman
LGTM, thanks.
3 years, 9 months ago (2017-03-17 20:24:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757833002/1
3 years, 9 months ago (2017-03-21 01:24:30 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 02:58:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b3e4fe434fa1165715fe60b49b4...

Powered by Google App Engine
This is Rietveld 408576698