|
|
DescriptionAdd transparent video input test for WebRtcMediaRecorderBrowserTest
This CL adds a test where canvas input with alpha is recorded.
BUG=690968
Review-Url: https://codereview.chromium.org/2757793002
Cr-Commit-Position: refs/heads/master@{#458176}
Committed: https://chromium.googlesource.com/chromium/src/+/09cc93d64e1794e3ac967c25ed6e356f0aab2146
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 26 (19 generated)
Description was changed from ========== add alpha test Add resized video input test for MediaRecorder This CL adds a new test where canvas input resizes during the recording. BUG=701450 patch from issue 2750373003 at patchset 20001 (http://crrev.com/2750373003#ps20001) ========== to ========== Add transparent video input test for WebRtcMediaRecorderBrowserTest This CL adds a test where canvas input with alpha is recorded. BUG=690968 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
I realized that all current content_browsertests are getUserMedia() based, so I added a canvas one to force alpha. PTAL.
lgtm w/ suggestion https://codereview.chromium.org/2757793002/diff/1/content/test/data/media/med... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/2757793002/diff/1/content/test/data/media/med... content/test/data/media/mediarecorder_test.html:542: function testTransparentVideoInput(mimeType) { micro-nit: s/testTransparentVideoInput/testRecordWithTransparency/ ?
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
The CQ bit was unchecked by emircan@chromium.org
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2757793002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2757793002/diff/1/content/test/data/media/med... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/2757793002/diff/1/content/test/data/media/med... content/test/data/media/mediarecorder_test.html:542: function testTransparentVideoInput(mimeType) { On 2017/03/17 01:16:48, mcasas wrote: > micro-nit: s/testTransparentVideoInput/testRecordWithTransparency/ ? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490038252137440, "parent_rev": "314b385358094f67c6afaaf5dabe3cbe1955dbd4", "commit_rev": "09cc93d64e1794e3ac967c25ed6e356f0aab2146"}
Message was sent while issue was closed.
Description was changed from ========== Add transparent video input test for WebRtcMediaRecorderBrowserTest This CL adds a test where canvas input with alpha is recorded. BUG=690968 ========== to ========== Add transparent video input test for WebRtcMediaRecorderBrowserTest This CL adds a test where canvas input with alpha is recorded. BUG=690968 Review-Url: https://codereview.chromium.org/2757793002 Cr-Commit-Position: refs/heads/master@{#458176} Committed: https://chromium.googlesource.com/chromium/src/+/09cc93d64e1794e3ac967c25ed6e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/09cc93d64e1794e3ac967c25ed6e... |