Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/protocol/ice_connection_to_client.cc

Issue 2757723002: Update ICE protocol to handle closed channel (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/fake_stream_socket.cc ('k') | remoting/protocol/ice_connection_to_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/ice_connection_to_client.cc
diff --git a/remoting/protocol/ice_connection_to_client.cc b/remoting/protocol/ice_connection_to_client.cc
index f2780c22908d15151aeb68dc3c294685c33d3c5f..90f9b1acdca011c67fafe942ad716feb1a7f84cf 100644
--- a/remoting/protocol/ice_connection_to_client.cc
+++ b/remoting/protocol/ice_connection_to_client.cc
@@ -189,7 +189,6 @@ void IceConnectionToClient::OnIceTransportRouteChange(
void IceConnectionToClient::OnIceTransportError(ErrorCode error) {
DCHECK(thread_checker_.CalledOnValidThread());
-
Disconnect(error);
}
@@ -202,8 +201,8 @@ void IceConnectionToClient::OnChannelInitialized(
void IceConnectionToClient::OnChannelClosed(
ChannelDispatcherBase* channel_dispatcher) {
- // ICE transport doesn't close channels dynamically.
- NOTREACHED();
+ DCHECK(thread_checker_.CalledOnValidThread());
+ Disconnect(OK);
}
void IceConnectionToClient::NotifyIfChannelsReady() {
« no previous file with comments | « remoting/protocol/fake_stream_socket.cc ('k') | remoting/protocol/ice_connection_to_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698