PPC/s390: [regexp] Port RegExpExecStub to CSA (mostly)

PPC/s390: [regexp] Port RegExpExecStub to CSA (mostly)

Port 5cc6189677066382dd206a68375b88e80ccd9afd

Minor fix to the original CL's port of ppc/s390

Original Commit Message:

    This moves most of the logic contained in RegExpExecStub to CSA.  Benefits are
    mostly easier readability and hackability, and removal of a large chunk of
    platform-specific assembly.

    Exit frame construction and the final call remain in RegExpExecStub.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=v8:5339, v8:592
LOG=N

Review-Url: https://codereview.chromium.org/2757673004
Cr-Commit-Position: refs/heads/master@{#43877}
Committed: https://chromium.googlesource.com/v8/v8/+/469b632e6599d518f83c30bf9f0d5f2f53c4ae15

[JaideepBajwa, 2017-03-16 19:38:40]

ptal

[john.yan, 2017-03-16 19:39:38]

lgtm

[JaideepBajwa, 2017-03-16 19:40:44]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2017-03-16 19:40:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:02:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489693244401560, "parent_rev":
"0e893511b36cf2eba6b1cb26b5ef6caac15554ab", "commit_rev":
"469b632e6599d518f83c30bf9f0d5f2f53c4ae15"}

[commit-bot: I haz the power, 2017-03-16 20:03:05]

Description was changed from

==========
PPC/s390: [regexp] Port RegExpExecStub to CSA (mostly)

Port 5cc6189677066382dd206a68375b88e80ccd9afd

Minor fix to the original CL's port of ppc/s390

Original Commit Message:

    This moves most of the logic contained in RegExpExecStub to CSA.  Benefits
are
    mostly easier readability and hackability, and removal of a large chunk of
    platform-specific assembly.

    Exit frame construction and the final call remain in RegExpExecStub.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:5339,v8:592
LOG=N
==========

to

==========
PPC/s390: [regexp] Port RegExpExecStub to CSA (mostly)

Port 5cc6189677066382dd206a68375b88e80ccd9afd

Minor fix to the original CL's port of ppc/s390

Original Commit Message:

    This moves most of the logic contained in RegExpExecStub to CSA.  Benefits
are
    mostly easier readability and hackability, and removal of a large chunk of
    platform-specific assembly.

    Exit frame construction and the final call remain in RegExpExecStub.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:5339,v8:592
LOG=N

Review-Url: https://codereview.chromium.org/2757673004
Cr-Commit-Position: refs/heads/master@{#43877}
Committed:
https://chromium.googlesource.com/v8/v8/+/469b632e6599d518f83c30bf9f0d5f2f53c...
==========

[commit-bot: I haz the power, 2017-03-16 20:03:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/469b632e6599d518f83c30bf9f0d5f2f53c...

[jgruber, 2017-03-17 07:15:49]

Thanks for the fixes!

https://codereview.chromium.org/2757673004/diff/1/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):

https://codereview.chromium.org/2757673004/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:1248: __ mov(ip,
Operand(address_of_regexp_stack_memory_size));
Out of curiosity, is ip not the instruction pointer? If it is, why can we
overwrite it?

[john.yan, 2017-03-17 13:48:42]

https://codereview.chromium.org/2757673004/diff/1/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):

https://codereview.chromium.org/2757673004/diff/1/src/ppc/code-stubs-ppc.cc#n...
src/ppc/code-stubs-ppc.cc:1248: __ mov(ip,
Operand(address_of_regexp_stack_memory_size));
On 2017/03/17 07:15:49, jgruber wrote:
> Out of curiosity, is ip not the instruction pointer? If it is, why can we
> overwrite it?

ip on ppc/s390 is the Inter Procedural register.