Chromium Code Reviews
Help | Chromium Project | Sign in
(98)

Issue 2757663002: ntp-snippets-internals: add fields, indent JSON (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by sfiera
Modified:
1 week, 1 day ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, arv+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ntp-snippets-internals: add fields, indent JSON I thought I had gotten a notification about an article the server hadn't said to notify for. It actually had, but the dump didn't include all of the fields for content suggestions there. This adds the current set of fields, and indents the JSON so it's easier to scan for relevant information. Even though it's only used for the webui, I'd be inclined in the future to move PrepareSuggestion() into the component and give it a test (and a better name). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2757663002 Cr-Commit-Position: refs/heads/master@{#458427} Committed: https://chromium.googlesource.com/chromium/src/+/378b4e8a2660f9dfc74abdc2b04f3ffcbdf93671

Patch Set 1 #

Patch Set 2 : Make llx work #

Messages

Total messages: 32 (23 generated)
sfiera
PTAL
1 week, 6 days ago (2017-03-16 14:24:47 UTC) #4
Marc Treib
lgtm Somewhat related: We had some discussions about removing all the special "ForDebugging" accessors, and ...
1 week, 6 days ago (2017-03-16 14:30:05 UTC) #5
sfiera
On 2017/03/16 14:30:05, Marc Treib wrote: > lgtm > > Somewhat related: We had some ...
1 week, 6 days ago (2017-03-16 14:44:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757663002/1
1 week, 6 days ago (2017-03-16 15:40:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/229173)
1 week, 6 days ago (2017-03-16 16:24:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757663002/1
1 week, 6 days ago (2017-03-16 17:31:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/138237)
1 week, 6 days ago (2017-03-16 18:28:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757663002/20001
1 week, 1 day ago (2017-03-21 14:56:01 UTC) #29
commit-bot: I haz the power
1 week, 1 day ago (2017-03-21 15:53:03 UTC) #32
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/378b4e8a2660f9dfc74abdc2b04f...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46