memory coordinator: Delay setting browsers memory state if needed

memory coordinator: Delay setting browsers memory state if needed

Before this CL memory coordinator ignored browser's memory state
change until |minimum_state_transition_period_| is passed. This
behavior caused inconsistency between the current memory pressure
and the browsers state. For example, the browser's memory state
could remain THROTTLED state when memory condition is quickly changed
from CRITICAL to NORMAL. The browser's state should be changed to
NORMAL after |minimum_state_transition_period_| is passed.

BUG=696844
Review-Url: https://codereview.chromium.org/2757653003
Cr-Commit-Position: refs/heads/master@{#458309}
Committed: https://chromium.googlesource.com/chromium/src/+/ff04f9a412991a4d83c2bf5422c6489d7ed086e1

[bashi, 2017-03-17 03:44:02]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 03:44:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 05:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 05:04:58]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-03-17 05:07:49]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, haraken@chromium.org

[bashi, 2017-03-17 05:07:50]

PTAL

[haraken, 2017-03-17 09:54:36]

LGTM

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:429:
base::TimeDelta::FromSeconds(1);

Why + 1 second?

[chrisha, 2017-03-20 19:30:29]

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.h (right):

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.h:119: virtual base::TimeTicks
Now();
Do we want to use the more common pattern of injecting a TickClock?

[bashi, 2017-03-21 01:10:07]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 01:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 03:13:56]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-03-21 04:29:32]

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.cc (right):

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.cc:429:
base::TimeDelta::FromSeconds(1);
On 2017/03/17 09:54:36, haraken wrote:
> 
> Why + 1 second?

That's an arbitrary time to make sure the task is scheduled after
minimum_state_transition_period_ - elapsed.

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_impl.h (right):

https://codereview.chromium.org/2757653003/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_impl.h:119: virtual base::TimeTicks
Now();
On 2017/03/20 19:30:29, chrisha wrote:
> Do we want to use the more common pattern of injecting a TickClock?

I wasn't aware of TickClock. Used it. Thanks for the info!

[bashi, 2017-03-21 04:29:40]

The CQ bit was checked by bashi@chromium.org

[bashi, 2017-03-21 04:29:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2757653003/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2017-03-21 04:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 04:33:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490070580260650,
"parent_rev": "6b9ac5c7d7b50d5e419eb9aadc8a52497b3fecb5", "commit_rev":
"ff04f9a412991a4d83c2bf5422c6489d7ed086e1"}

[commit-bot: I haz the power, 2017-03-21 04:38:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490070580260650,
"parent_rev": "6b9ac5c7d7b50d5e419eb9aadc8a52497b3fecb5", "commit_rev":
"ff04f9a412991a4d83c2bf5422c6489d7ed086e1"}

[commit-bot: I haz the power, 2017-03-21 04:39:20]

Description was changed from

==========
memory coordinator: Delay setting browsers memory state if needed

Before this CL memory coordinator ignored browser's memory state
change until |minimum_state_transition_period_| is passed. This
behavior caused inconsistency between the current memory pressure
and the browsers state. For example, the browser's memory state
could remain THROTTLED state when memory condition is quickly changed
from CRITICAL to NORMAL. The browser's state should be changed to
NORMAL after |minimum_state_transition_period_| is passed.

BUG=696844
==========

to

==========
memory coordinator: Delay setting browsers memory state if needed

Before this CL memory coordinator ignored browser's memory state
change until |minimum_state_transition_period_| is passed. This
behavior caused inconsistency between the current memory pressure
and the browsers state. For example, the browser's memory state
could remain THROTTLED state when memory condition is quickly changed
from CRITICAL to NORMAL. The browser's state should be changed to
NORMAL after |minimum_state_transition_period_| is passed.

BUG=696844

Review-Url: https://codereview.chromium.org/2757653003
Cr-Commit-Position: refs/heads/master@{#458309}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff04f9a412991a4d83c2bf5422c6...
==========

[commit-bot: I haz the power, 2017-03-21 04:39:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff04f9a412991a4d83c2bf5422c6...