Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2757563003: Remove SurfaceFactory::Reset (Closed)

Created:
3 years, 9 months ago by Saman Sami
Modified:
3 years, 9 months ago
Reviewers:
Fady Samuel, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SurfaceFactory::Reset It's not used anymore. We instead recreate the CompositorFrameSinkSupport object on gpu restart. This is because the CompositorFrameSinkSupport will eventually live in the gpu process and will be destroyed on gpu restart, therefore it can't have a Reset method like SurfaceFactory. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757563003 Cr-Commit-Position: refs/heads/master@{#457453} Committed: https://chromium.googlesource.com/chromium/src/+/ed13215635f34ea3026cbb0da8c91dad903815dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -92 lines) Patch
M cc/surfaces/surface_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Saman Sami
PTAL
3 years, 9 months ago (2017-03-16 15:02:51 UTC) #6
Fady Samuel
LGTM, but please ask piman@ to review this since he wrote it.
3 years, 9 months ago (2017-03-16 15:04:40 UTC) #8
Saman Sami
Thanks! piman@ PTAL
3 years, 9 months ago (2017-03-16 15:05:30 UTC) #10
piman
On 2017/03/16 15:05:30, Saman Sami wrote: > Thanks! > > piman@ PTAL LGTM. It's not ...
3 years, 9 months ago (2017-03-16 15:54:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757563003/1
3 years, 9 months ago (2017-03-16 16:14:29 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 16:19:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed13215635f34ea3026cbb0da8c9...

Powered by Google App Engine
This is Rietveld 408576698