Editing: Content of display:table elements should be editable.

Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't want to change TextIterator behavior, this CL copies the old
implementation of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315
Review-Url: https://codereview.chromium.org/2757553002
Cr-Commit-Position: refs/heads/master@{#457393}
Committed: https://chromium.googlesource.com/chromium/src/+/af861c1f7d2bfe863febea4fd6a5d14483c30b48

[tkent, 2017-03-16 04:49:41]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 04:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 05:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 05:26:28]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tkent, 2017-03-16 05:39:52]

Description was changed from

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

BUG=697315
==========

to

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

BUG=697315
==========

[tkent, 2017-03-16 06:57:00]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 06:57:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-16 07:01:16]

Patchset #1 (id:1) has been deleted

[tkent, 2017-03-16 08:14:47]

Description was changed from

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

BUG=697315
==========

to

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't change TextIterator behavior, this CL copies the old
implementation
of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315
==========

[tkent, 2017-03-16 08:16:21]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2017-03-16 08:16:22]

yosin@, would you review this please?

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/deleting/display-table.html (left):

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/deleting/display-table.html:31: }, "This
test verifies that we are able to successfully delete the first and the last
characters of a contenteditable div with display: table.");
The test was very inconsistent.  The description said we should be able to
delete, but the actual test asserts that we can't delete.

[tkent, 2017-03-16 08:21:44]

Description was changed from

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't change TextIterator behavior, this CL copies the old
implementation
of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315
==========

to

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't want to change TextIterator behavior, this CL copies the old
implementation of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315
==========

[commit-bot: I haz the power, 2017-03-16 08:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 08:44:27]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-16 08:57:33]

lgtm with small nit.

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right):

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:154: return
(layoutObject && layoutObject->isTable());
nit: Please omit surrounding parenthesis.

[tkent, 2017-03-16 09:02:50]

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right):

https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:154: return
(layoutObject && layoutObject->isTable());
On 2017/03/16 at 08:57:33, yosin_UTC9 wrote:
> nit: Please omit surrounding parenthesis.

Done.

[tkent, 2017-03-16 09:03:02]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-16 09:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2757553002/#ps40001
(title: "Remove parenthesis")

[commit-bot: I haz the power, 2017-03-16 09:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 10:45:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489654982923720,
"parent_rev": "96f0a2b238852a56c0a30aa67f4a6943c5271688", "commit_rev":
"af861c1f7d2bfe863febea4fd6a5d14483c30b48"}

[commit-bot: I haz the power, 2017-03-16 10:46:32]

Description was changed from

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't want to change TextIterator behavior, this CL copies the old
implementation of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315
==========

to

==========
Editing: Content of display:table elements should be editable.

There are no problems with adding arbitrary content to an element with
display:table if it's not <table>.

This CL fixes broken editing/deleting/display-table.html.

Because we don't want to change TextIterator behavior, this CL copies the old
implementation of isDispalyInsideTable() to TextIterator.cpp.

BUG=697315

Review-Url: https://codereview.chromium.org/2757553002
Cr-Commit-Position: refs/heads/master@{#457393}
Committed:
https://chromium.googlesource.com/chromium/src/+/af861c1f7d2bfe863febea4fd6a5...
==========

[commit-bot: I haz the power, 2017-03-16 10:46:33]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/af861c1f7d2bfe863febea4fd6a5...