Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2757553002: Editing: Content of display:table elements should be editable. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Content of display:table elements should be editable. There are no problems with adding arbitrary content to an element with display:table if it's not <table>. This CL fixes broken editing/deleting/display-table.html. Because we don't want to change TextIterator behavior, this CL copies the old implementation of isDispalyInsideTable() to TextIterator.cpp. BUG=697315 Review-Url: https://codereview.chromium.org/2757553002 Cr-Commit-Position: refs/heads/master@{#457393} Committed: https://chromium.googlesource.com/chromium/src/+/af861c1f7d2bfe863febea4fd6a5d14483c30b48

Patch Set 1 : . #

Total comments: 3

Patch Set 2 : Remove parenthesis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/editing/deleting/display-table.html View 1 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
tkent
yosin@, would you review this please? https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/display-table.html File third_party/WebKit/LayoutTests/editing/deleting/display-table.html (left): https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/display-table.html#oldcode31 third_party/WebKit/LayoutTests/editing/deleting/display-table.html:31: }, "This test ...
3 years, 9 months ago (2017-03-16 08:16:22 UTC) #11
yosin_UTC9
lgtm with small nit. https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right): https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp#newcode154 third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:154: return (layoutObject && layoutObject->isTable()); nit: ...
3 years, 9 months ago (2017-03-16 08:57:33 UTC) #15
tkent
https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right): https://codereview.chromium.org/2757553002/diff/20001/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp#newcode154 third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:154: return (layoutObject && layoutObject->isTable()); On 2017/03/16 at 08:57:33, yosin_UTC9 ...
3 years, 9 months ago (2017-03-16 09:02:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757553002/40001
3 years, 9 months ago (2017-03-16 09:03:18 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 10:46:33 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/af861c1f7d2bfe863febea4fd6a5...

Powered by Google App Engine
This is Rietveld 408576698