Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 2757543006: DevTools: remove dead frontend_url param from DevToolsWindow::Create. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 kClosing 245 kClosing
246 }; 246 };
247 247
248 DevToolsWindow(Profile* profile, 248 DevToolsWindow(Profile* profile,
249 content::WebContents* main_web_contents, 249 content::WebContents* main_web_contents,
250 DevToolsUIBindings* bindings, 250 DevToolsUIBindings* bindings,
251 content::WebContents* inspected_web_contents, 251 content::WebContents* inspected_web_contents,
252 bool can_dock); 252 bool can_dock);
253 253
254 static DevToolsWindow* Create(Profile* profile, 254 static DevToolsWindow* Create(Profile* profile,
255 const GURL& frontend_url,
256 content::WebContents* inspected_web_contents, 255 content::WebContents* inspected_web_contents,
257 bool shared_worker_frontend, 256 bool shared_worker_frontend,
258 bool v8_only_frontend, 257 bool v8_only_frontend,
259 bool node_frontend, 258 bool node_frontend,
260 const std::string& remote_frontend, 259 const std::string& remote_frontend,
261 bool can_dock, 260 bool can_dock,
262 const std::string& settings, 261 const std::string& settings,
263 const std::string& panel); 262 const std::string& panel);
264 static GURL GetDevToolsURL(Profile* profile, 263 static GURL GetDevToolsURL(Profile* profile,
265 const GURL& base_url,
266 bool shared_worker_frontend, 264 bool shared_worker_frontend,
267 bool v8_only_frontend, 265 bool v8_only_frontend,
268 bool node_frontend, 266 bool node_frontend,
269 const std::string& remote_frontend, 267 const std::string& remote_frontend,
270 bool can_dock, 268 bool can_dock,
271 const std::string& panel); 269 const std::string& panel);
272 270
273 static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile); 271 static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile);
274 static void ToggleDevToolsWindow( 272 static void ToggleDevToolsWindow(
275 content::WebContents* web_contents, 273 content::WebContents* web_contents,
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 base::Closure ready_for_test_callback_; 361 base::Closure ready_for_test_callback_;
364 362
365 base::TimeTicks inspect_element_start_time_; 363 base::TimeTicks inspect_element_start_time_;
366 std::unique_ptr<DevToolsEventForwarder> event_forwarder_; 364 std::unique_ptr<DevToolsEventForwarder> event_forwarder_;
367 365
368 friend class DevToolsEventForwarder; 366 friend class DevToolsEventForwarder;
369 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 367 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
370 }; 368 };
371 369
372 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 370 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698