|
|
Chromium Code Reviews
DescriptionDo not print enforcing Ignition and TurboFan when --turbo is on
BUG=
Review-Url: https://codereview.chromium.org/2757543004
Cr-Commit-Position: refs/heads/master@{#44605}
Committed: https://chromium.googlesource.com/v8/v8/+/a5f91b3a95e1424a6621b6aefe2e77736c7ba3ff
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
mic.besace@gmail.com changed reviewers: + adamk@chromium.org, franzih@chromium.org
Example result with Node.js:
$ ./node --trace-opt -p 'for(var i=0;i<1e6;i++){}'
[marking 0x23d098065c69 <JSFunction (sfi = 0x23d098065961)> for optimized
recompilation, reason: small function, ICs with typeinfo: 4/5 (80%), generic
ICs: 0/5 (0%)]
[compiling method 0x23d098065c69 <JSFunction (sfi = 0x23d098065961)> using
TurboFan OSR]
[optimizing 0x23d098065c69 <JSFunction (sfi = 0x23d098065961)> - took 0.155,
0.287, 0.037 ms]
undefined
$ ./node --no-turbo --trace-opt -p 'for(var i=0;i<1e6;i++){}'
[enforcing Ignition and TurboFan for NativeModule.compile because:
TryFinallyStatement
[enforcing Ignition and TurboFan for because: Class literal
[enforcing Ignition and TurboFan for createUnsafeArrayBuffer because:
TryFinallyStatement
[enforcing Ignition and TurboFan for Uint32Array because: Super reference
[enforcing Ignition and TurboFan for Float64Array because: Super reference
[enforcing Ignition and TurboFan for Join because: TryFinallyStatement
[enforcing Ignition and TurboFan for WeakMap because: TryCatchStatement
[enforcing Ignition and TurboFan for because: Computed property name
[enforcing Ignition and TurboFan for defineIDLClass because: TryCatchStatement
[enforcing Ignition and TurboFan for Map because: TryCatchStatement
[enforcing Ignition and TurboFan for tryGetCwd because: TryFinallyStatement
[enforcing Ignition and TurboFan for tryOnImmediate because: TryFinallyStatement
[enforcing Ignition and TurboFan for require because: TryFinallyStatement
[marking 0x27cae3b60881 <JSFunction (sfi = 0x27cae3b605a9)> for optimized
recompilation, reason: small function, ICs with typeinfo: 4/5 (80%), generic
ICs: 0/5 (0%)]
[compiling method 0x27cae3b60881 <JSFunction (sfi = 0x27cae3b605a9)> using
Crankshaft OSR]
[optimizing 0x27cae3b60881 <JSFunction (sfi = 0x27cae3b605a9)> - took 0.048,
0.083, 0.021 ms]
[enforcing Ignition and TurboFan for installInspectorConsoleIfNeeded because:
TryCatchStatement
[enforcing Ignition and TurboFan for log because: Rest parameters
[enforcing Ignition and TurboFan for formatValue because: TryCatchStatement
[enforcing Ignition and TurboFan for write because: TryCatchStatement
undefined
Ping.
Description was changed from ========== Do not print enforcing Ignition and TurboFan when --turbo is on BUG= ========== to ========== Do not print enforcing Ignition and TurboFan when --turbo is on BUG= ==========
franzih@chromium.org changed reviewers: + bmeurer@chromium.org
@bmeurer, can you have a look at this? Thanks, Franzi
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Makes sense, thanks! LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491993069062100, "parent_rev":
"53f13a09ba7553e8e0792cb987fb446b9ac1ddb0", "commit_rev":
"a5f91b3a95e1424a6621b6aefe2e77736c7ba3ff"}
Message was sent while issue was closed.
Description was changed from ========== Do not print enforcing Ignition and TurboFan when --turbo is on BUG= ========== to ========== Do not print enforcing Ignition and TurboFan when --turbo is on BUG= Review-Url: https://codereview.chromium.org/2757543004 Cr-Commit-Position: refs/heads/master@{#44605} Committed: https://chromium.googlesource.com/v8/v8/+/a5f91b3a95e1424a6621b6aefe2e77736c7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a5f91b3a95e1424a6621b6aefe2e77736c7... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
