Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2757513002: Revert of Account for overlay scrollbars when computing scrollbar width/height. (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
skobes, szager1
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Account for overlay scrollbars when computing scrollbar width/height. (patchset #4 id:60001 of https://codereview.chromium.org/2725763002/ ) Reason for revert: A layout test gets red after this CL due to the mismatched test expectation. The error log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13521 Original issue's description: > Account for overlay scrollbars when computing scrollbar width/height. > > This specifically addresses overlay scrollbars created via css with > overflow:overlay. In some places, those scrollbars are treated > differently from overlay scrollbars created by the platform theme > (e.g., on mac). > > BUG=657718 > R=skobes@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2725763002 > Cr-Commit-Position: refs/heads/master@{#454105} > Committed: https://chromium.googlesource.com/chromium/src/+/5a729d1bc790d94120ec942a4566bb85f969cdb1 TBR=skobes@chromium.org,szager@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=657718

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
tzik
Created Revert of Account for overlay scrollbars when computing scrollbar width/height.
3 years, 9 months ago (2017-03-16 02:08:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757513002/1
3 years, 9 months ago (2017-03-16 02:08:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:11:09 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698