Chromium Code Reviews
Help | Chromium Project | Sign in
(79)

Issue 2757493002: User orientation lock

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by oshima
Modified:
11 hours, 52 minutes ago
Reviewers:
jonross, benwells, mlamouri
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

User orientation lock * Added user locked orientation. Once it's locked, the orientation will be used as a preferred orientation. - If the active appilcation's orientation is any, the user locked orientation will be used. - If the active appilcation's orientation is specified, the user locked orientation will be ignored and uses the application's orientation. * Exclude windows that does not have AppType because they do not control orientation into account. For example, task manager, app list shouldn't affect orientation. * added ScreenOrientationControllerTestApi Next steps: - landscape / portrait app should lock to secondary/primary. - remember and restore the locked state. - handle rotation change from chrome.system.display api. - Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI. BUG=683456 TEST=manual, unitt tests

Patch Set 1 : . #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -105 lines) Patch
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 22 chunks +176 lines, -32 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 5 chunks +27 lines, -10 lines 4 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 9 chunks +117 lines, -40 lines 9 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 8 chunks +13 lines, -12 lines 3 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M ash/test/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/test/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/test/screen_orientation_controller_test_api.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ash/test/screen_orientation_controller_test_api.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 46 (38 generated)
oshima
https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.h File ash/display/screen_orientation_controller_chromeos.h (right): https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.h#newcode80 ash/display/screen_orientation_controller_chromeos.h:80: void ToggleUserRotationLock(); I'm using toggle instead of SetUserRotationLock to ...
2 days, 9 hours ago (2017-03-21 07:11:53 UTC) #34
jonross
https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc File ash/display/screen_orientation_controller_chromeos.cc (left): https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc#oldcode142 ash/display/screen_orientation_controller_chromeos.cc:142: Shell::GetInstance()->display_manager()->RegisterDisplayRotationProperties( Were you planning to land this in a ...
2 days, 1 hour ago (2017-03-21 14:56:44 UTC) #36
oshima
https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc File ash/display/screen_orientation_controller_chromeos.cc (left): https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc#oldcode142 ash/display/screen_orientation_controller_chromeos.cc:142: Shell::GetInstance()->display_manager()->RegisterDisplayRotationProperties( On 2017/03/21 14:56:43, jonross wrote: > Were you ...
2 days, 1 hour ago (2017-03-21 15:10:57 UTC) #38
oshima
ping?
17 hours, 5 minutes ago (2017-03-22 23:17:35 UTC) #40
jonross
On 2017/03/22 23:17:35, oshima wrote: > ping? Sorry I somehow missed the replies you sent ...
16 hours, 31 minutes ago (2017-03-22 23:51:46 UTC) #41
jonross
https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc File ash/display/screen_orientation_controller_chromeos.cc (left): https://codereview.chromium.org/2757493002/diff/220001/ash/display/screen_orientation_controller_chromeos.cc#oldcode142 ash/display/screen_orientation_controller_chromeos.cc:142: Shell::GetInstance()->display_manager()->RegisterDisplayRotationProperties( On 2017/03/21 15:10:57, oshima wrote: > On 2017/03/21 ...
16 hours, 31 minutes ago (2017-03-22 23:51:56 UTC) #42
oshima
benwells@ -> chrome/browser/extensions mlamouri@chromium.org -> ash/test/DEPS
15 hours, 57 minutes ago (2017-03-23 00:25:51 UTC) #44
benwells
11 hours, 52 minutes ago (2017-03-23 04:31:05 UTC) #46
c/b/e lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62