Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
TBR=dfalcantara

Review-Url: https://codereview.chromium.org/2757483002
Cr-Commit-Position: refs/heads/master@{#460005}
Committed: https://chromium.googlesource.com/chromium/src/+/4187ef8e65b069e4d3e5645446ad04ebdb1c527e

[Timothy Loh, 2017-03-16 00:29:56]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-03-16 00:37:42]

Description was changed from

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> from
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
==========

to

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
==========

[Timothy Loh, 2017-03-16 00:38:37]

timloh@chromium.org changed reviewers:
+ dominickn@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:34:54]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-03-16 03:55:07]

Thanks Tim!

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:74: requests_.clear();
Should requests be cleared before or after calling the delegate method? Seems a
bit weird to clear it first.

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:7: 
Nit: #include <vector>

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:10: class InfoBarService;
nit: class PermissionRequest;

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:40: const
std::vector<PermissionRequest*>& Requests() { return requests_; }
Instead of exposing the requests directly, I think it's nicer to have
GetContentSettingsType etc methods on PermissionPromptAndroid which take a
position and then internally operate on the appropriate request.

Similarly PermissionCount() should delegate to PermissionPromptAndroid.

[Timothy Loh, 2017-03-16 07:33:37]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 07:33:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 07:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 07:35:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Timothy Loh, 2017-03-17 00:45:31]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 00:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-03-17 00:47:27]

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.cc (right):

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.cc:74: requests_.clear();
On 2017/03/16 03:55:07, dominickn wrote:
> Should requests be cleared before or after calling the delegate method? Seems
a
> bit weird to clear it first.

If we have a queued request, the PermissionRequestManager will Show() it,
assigning a new value to the vector, so we can't clear it after.

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:7: 
On 2017/03/16 03:55:07, dominickn wrote:
> Nit: #include <vector>

Done.

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:10: class InfoBarService;
On 2017/03/16 03:55:07, dominickn wrote:
> nit: class PermissionRequest;

Done.

https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_prompt_android.h:40: const
std::vector<PermissionRequest*>& Requests() { return requests_; }
On 2017/03/16 03:55:07, dominickn wrote:
> Instead of exposing the requests directly, I think it's nicer to have
> GetContentSettingsType etc methods on PermissionPromptAndroid which take a
> position and then internally operate on the appropriate request.
> 
> Similarly PermissionCount() should delegate to PermissionPromptAndroid.

Done.

[commit-bot: I haz the power, 2017-03-17 01:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:27:53]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-03-17 01:48:13]

lgtm, thanks!

https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissi...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissi...
chrome/browser/permissions/permission_prompt_android.h:14: class InfoBarService;
I don't think InfoBarService is needed.

[Timothy Loh, 2017-03-17 02:22:41]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 02:23:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-03-17 02:23:14]

https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissi...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissi...
chrome/browser/permissions/permission_prompt_android.h:14: class InfoBarService;
On 2017/03/17 01:48:13, dominickn wrote:
> I don't think InfoBarService is needed.

Done.

[Timothy Loh, 2017-03-17 02:49:58]

timloh@chromium.org changed reviewers:
+ benwells@chromium.org

[Timothy Loh, 2017-03-17 02:49:58]

+benwells@ for OWNERS, thanks!

[commit-bot: I haz the power, 2017-03-17 02:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:58:49]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-03-20 03:10:43]

lgtm withanit

https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissi...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissi...
chrome/browser/permissions/permission_prompt_android.h:44: size_t
PermissionCount() const { return requests_.size(); }
Nit: use unix_hacker_style for inline function name.

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[Timothy Loh, 2017-03-28 02:48:15]

https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissi...
File chrome/browser/permissions/permission_prompt_android.h (right):

https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissi...
chrome/browser/permissions/permission_prompt_android.h:44: size_t
PermissionCount() const { return requests_.size(); }
On 2017/03/20 03:10:43, benwells wrote:
> Nit: use unix_hacker_style for inline function name.
> 
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

Done.

[Timothy Loh, 2017-03-28 02:48:39]

timloh@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Timothy Loh, 2017-03-28 02:48:54]

Description was changed from

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
==========

to

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
TBR=dfalcantara
==========

[Timothy Loh, 2017-03-28 02:49:17]

tbr-ing dfalcantara for a trivial change in 
chrome/browser/ui/android/infobars/grouped_permission_infobar.cc

[Timothy Loh, 2017-03-28 02:49:23]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2017-03-28 02:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2757483002/#ps80001
(title: "rename inline function")

[commit-bot: I haz the power, 2017-03-28 02:49:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 02:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 02:53:22]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Timothy Loh, 2017-03-28 03:10:04]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:10:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:45:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490670604050830,
"parent_rev": "827f29b097efd519b9248d0bcf8e8432c43918e6", "commit_rev":
"4187ef8e65b069e4d3e5645446ad04ebdb1c527e"}

[commit-bot: I haz the power, 2017-03-28 03:46:31]

Description was changed from

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
TBR=dfalcantara
==========

to

==========
Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid

This patch moves the Vector<PermissionRequest> stored in
GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will
allow us to later share the PermissionPromptAndroid class in
PermissionDialogDelegate as storage for this same vector, as we already
will need such a pointer to delegate the the user action callbacks.

BUG=606138
TBR=dfalcantara

Review-Url: https://codereview.chromium.org/2757483002
Cr-Commit-Position: refs/heads/master@{#460005}
Committed:
https://chromium.googlesource.com/chromium/src/+/4187ef8e65b069e4d3e5645446ad...
==========

[commit-bot: I haz the power, 2017-03-28 03:46:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4187ef8e65b069e4d3e5645446ad...

[gone, 2017-03-28 16:38:05]

post-commit lgtm