Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2757483002: Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid (Closed)

Created:
3 years, 9 months ago by Timothy Loh
Modified:
3 years, 8 months ago
Reviewers:
dominickn, benwells, gone
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move requests from GroupedPermissionInfoBarDelegate to PermissionPromptAndroid This patch moves the Vector<PermissionRequest> stored in GroupedPermissionInfoBarDelegate to PermissionPromptAndroid. This will allow us to later share the PermissionPromptAndroid class in PermissionDialogDelegate as storage for this same vector, as we already will need such a pointer to delegate the the user action callbacks. BUG=606138 TBR=dfalcantara Review-Url: https://codereview.chromium.org/2757483002 Cr-Commit-Position: refs/heads/master@{#460005} Committed: https://chromium.googlesource.com/chromium/src/+/4187ef8e65b069e4d3e5645446ad04ebdb1c527e

Patch Set 1 #

Total comments: 8

Patch Set 2 : addr comments #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rm infobarservice fwd decl #

Total comments: 2

Patch Set 5 : rename inline function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -32 lines) Patch
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.h View 4 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc View 1 2 3 4 4 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.h View 1 2 3 4 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_prompt_android.cc View 1 3 chunks +23 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 41 (27 generated)
Timothy Loh
3 years, 9 months ago (2017-03-16 00:38:37 UTC) #5
dominickn
Thanks Tim! https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/permission_prompt_android.cc File chrome/browser/permissions/permission_prompt_android.cc (right): https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/permission_prompt_android.cc#newcode74 chrome/browser/permissions/permission_prompt_android.cc:74: requests_.clear(); Should requests be cleared before or ...
3 years, 9 months ago (2017-03-16 03:55:07 UTC) #8
Timothy Loh
https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/permission_prompt_android.cc File chrome/browser/permissions/permission_prompt_android.cc (right): https://codereview.chromium.org/2757483002/diff/1/chrome/browser/permissions/permission_prompt_android.cc#newcode74 chrome/browser/permissions/permission_prompt_android.cc:74: requests_.clear(); On 2017/03/16 03:55:07, dominickn wrote: > Should requests ...
3 years, 9 months ago (2017-03-17 00:47:27 UTC) #15
dominickn
lgtm, thanks! https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissions/permission_prompt_android.h File chrome/browser/permissions/permission_prompt_android.h (right): https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissions/permission_prompt_android.h#newcode14 chrome/browser/permissions/permission_prompt_android.h:14: class InfoBarService; I don't think InfoBarService is ...
3 years, 9 months ago (2017-03-17 01:48:13 UTC) #18
Timothy Loh
https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissions/permission_prompt_android.h File chrome/browser/permissions/permission_prompt_android.h (right): https://codereview.chromium.org/2757483002/diff/40001/chrome/browser/permissions/permission_prompt_android.h#newcode14 chrome/browser/permissions/permission_prompt_android.h:14: class InfoBarService; On 2017/03/17 01:48:13, dominickn wrote: > I ...
3 years, 9 months ago (2017-03-17 02:23:14 UTC) #21
Timothy Loh
+benwells@ for OWNERS, thanks!
3 years, 9 months ago (2017-03-17 02:49:58 UTC) #23
benwells
lgtm withanit https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissions/permission_prompt_android.h File chrome/browser/permissions/permission_prompt_android.h (right): https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissions/permission_prompt_android.h#newcode44 chrome/browser/permissions/permission_prompt_android.h:44: size_t PermissionCount() const { return requests_.size(); } ...
3 years, 9 months ago (2017-03-20 03:10:43 UTC) #26
Timothy Loh
https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissions/permission_prompt_android.h File chrome/browser/permissions/permission_prompt_android.h (right): https://codereview.chromium.org/2757483002/diff/60001/chrome/browser/permissions/permission_prompt_android.h#newcode44 chrome/browser/permissions/permission_prompt_android.h:44: size_t PermissionCount() const { return requests_.size(); } On 2017/03/20 ...
3 years, 9 months ago (2017-03-28 02:48:15 UTC) #27
Timothy Loh
tbr-ing dfalcantara for a trivial change in chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
3 years, 9 months ago (2017-03-28 02:49:17 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757483002/80001
3 years, 9 months ago (2017-03-28 02:49:57 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/376027)
3 years, 9 months ago (2017-03-28 02:53:22 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757483002/80001
3 years, 9 months ago (2017-03-28 03:10:43 UTC) #37
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4187ef8e65b069e4d3e5645446ad04ebdb1c527e
3 years, 9 months ago (2017-03-28 03:46:32 UTC) #40
gone
3 years, 8 months ago (2017-03-28 16:38:05 UTC) #41
Message was sent while issue was closed.
post-commit lgtm

Powered by Google App Engine
This is Rietveld 408576698