Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2757473002: Cosmetic changes to chrome://net-export, primarily for desktop mode. (Closed)

Created:
3 years, 9 months ago by eroman
Modified:
3 years, 9 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, bnc+watch_chromium.org, mmenke, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cosmetic changes to chrome://net-export, primarily for desktop mode. * On the desktop UI, remove reference to emailing from the instructions (as that is only available from the mobile version). * While logging is in progress, change the disabled button's text from: "Start Logging to Disk" to "Logging to Disk..." This gives a bit more feedback that something is happening (even better would be to show the path to log file and its size) * Add a <title> for the page of "Network Log Export" BUG=701033, 701993 Review-Url: https://codereview.chromium.org/2757473002 Cr-Commit-Position: refs/heads/master@{#457612} Committed: https://chromium.googlesource.com/chromium/src/+/62a3acd978daee61b3ea99b4cd705d4401203ee3

Patch Set 1 #

Total comments: 2

Patch Set 2 : address Helen's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -36 lines) Patch
M chrome/browser/ui/webui/net_export_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/net_log/resources/net_export.css View 1 chunk +6 lines, -0 lines 0 comments Download
M components/net_log/resources/net_export.html View 1 1 chunk +31 lines, -18 lines 0 comments Download
M components/net_log/resources/net_export.js View 5 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
eroman
3 years, 9 months ago (2017-03-16 00:28:20 UTC) #4
xunjieli
I tried the change on desktop and on Android. I can see why the "Advanced" ...
3 years, 9 months ago (2017-03-16 19:49:49 UTC) #8
eroman
Thanks for the review! Agreed the capture modes are still confusing. I think we have ...
3 years, 9 months ago (2017-03-16 21:46:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757473002/20001
3 years, 9 months ago (2017-03-16 21:49:18 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:53:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/62a3acd978daee61b3ea99b4cd70...

Powered by Google App Engine
This is Rietveld 408576698