[Merge to M58] cros: Fix shelf overlaps bottom of maximized window in guest session

[Merge to M58] cros: Fix shelf overlaps bottom of maximized window in guest session

Changes:
CL in https://codereview.chromium.org/2688353005 makes change that leave the shelf bottom locked and hidden until user prefs are loaded. When ChromeLauncherController::SetShelfBehaviorsFromPrefs(), it will be blocked on https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_controller.cc?l=96, which leaves shelf alignment bottom locked in guest session.

We don't set display work area change for bottom locked, that is why bug happens.

Solution is to delete the CanChangeShelfAlignment() check as it should be enforced on shelf context menu already.

TBR=msw@chromium.org, jamescook@chromium.org
BUG=699661
TEST=emulator test saw reporter's bug fixed

Review-Url: https://codereview.chromium.org/2748983004
Cr-Commit-Position: refs/heads/master@{#457246}
(cherry picked from commit 5859fcdeb7fa7508f902d80d401958c956cb964f)

Review-Url: https://codereview.chromium.org/2757453002 .
Cr-Commit-Position: refs/branch-heads/3029@{#221}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/05f8c49347384a74e7081d0b1947a61406f96677

[Qiang(Joe) Xu, 2017-03-15 23:32:57]

Description was changed from

==========
[Merge to M58] cros: Fix shelf overlaps bottom of maximized window in guest
session

Changes:
CL in https://codereview.chromium.org/2688353005 makes change that leave the
shelf bottom locked and hidden until user prefs are loaded. When
ChromeLauncherController::SetShelfBehaviorsFromPrefs(), it will be blocked on
https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_controller.cc?l=96,
which leaves shelf alignment bottom locked in guest session.

We don't set display work area change for bottom locked, that is why bug
happens.

Solution is to delete the CanChangeShelfAlignment() check as it should be
enforced on shelf context menu already.

TBR=msw@chromium.org, jamescook@chromium.org
BUG=699661
TEST=emulator test saw reporter's bug fixed

Review-Url: https://codereview.chromium.org/2748983004
Cr-Commit-Position: refs/heads/master@{#457246}
(cherry picked from commit 5859fcdeb7fa7508f902d80d401958c956cb964f)
==========

to

==========
[Merge to M58] cros: Fix shelf overlaps bottom of maximized window in guest
session

Changes:
CL in https://codereview.chromium.org/2688353005 makes change that leave the
shelf bottom locked and hidden until user prefs are loaded. When
ChromeLauncherController::SetShelfBehaviorsFromPrefs(), it will be blocked on
https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_controller.cc?l=96,
which leaves shelf alignment bottom locked in guest session.

We don't set display work area change for bottom locked, that is why bug
happens.

Solution is to delete the CanChangeShelfAlignment() check as it should be
enforced on shelf context menu already.

TBR=msw@chromium.org, jamescook@chromium.org
BUG=699661
TEST=emulator test saw reporter's bug fixed

Review-Url: https://codereview.chromium.org/2748983004
Cr-Commit-Position: refs/heads/master@{#457246}
(cherry picked from commit 5859fcdeb7fa7508f902d80d401958c956cb964f)

Review-Url: https://codereview.chromium.org/2757453002 .
Cr-Commit-Position: refs/branch-heads/3029@{#221}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/05f8c49347384a74e7081d0b1947...
==========

[Qiang(Joe) Xu, 2017-03-15 23:32:58]

Committed patchset #1 (id:1) manually as
05f8c49347384a74e7081d0b1947a61406f96677 (presubmit successful).

[msw, 2017-03-15 23:35:38]

lgtm