Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 2757333003: MD Settings: Restore message shown when no "zoom" exceptions exist. (Closed)

Created:
10 months ago by dpapad
Modified:
10 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore message shown when no "zoom" exceptions exist. BUG=703030 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2757333003 Cr-Commit-Position: refs/heads/master@{#458202} Committed: https://chromium.googlesource.com/chromium/src/+/faa75b549b2c1395e4fb633ff68551d0dd70ddae

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/resources/settings/site_settings/zoom_levels.html View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/zoom_levels_tests.js View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dpapad
10 months ago (2017-03-20 18:28:37 UTC) #4
tommycli
lgtm thanks
10 months ago (2017-03-20 18:30:05 UTC) #6
dpapad
On 2017/03/20 at 18:30:05, tommycli wrote: > lgtm thanks Fastest review ever! Thanks!
10 months ago (2017-03-20 18:31:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757333003/20001
10 months ago (2017-03-20 18:50:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/331776)
10 months ago (2017-03-20 19:26:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757333003/20001
10 months ago (2017-03-20 20:45:11 UTC) #14
commit-bot: I haz the power
10 months ago (2017-03-20 22:25:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/faa75b549b2c1395e4fb633ff685...

Powered by Google App Engine
This is Rietveld 408576698