Remove all external references to ContentView from Tab/Shell/etc.

Remove all external references to ContentView from Tab/Shell/etc.

Cleanups:
- most places now directly use ContentViewCore instead of ContentView
- ContentView.getContentViewCore is removed (as you should be using
  CVC directly and CVC.getContainerView())
- Tab.getContentView is removed. Use Tab.getView or
  Tab.getContentViewCore().getContainerView(), with the latter being for
  content rendered without android views.

BUG=360664
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270762

[Yaron, 2014-05-09 02:43:04]

I think this ought to do it for turning the 2 mega classes into one. Still
plenty more clean-up we can do around it, but I think it'll help being able to
pick stuff off CVC

https://codereview.chromium.org/275733002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/275733002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:921: * Destroys the
current {@link WebContents}.
update

[Yaron, 2014-05-09 02:43:52]

red bots are sadly from broken tree

[Ted C, 2014-05-12 23:50:56]

lgtm

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:450: return
mNativePage != null ? mNativePage.getView() : (
I think the ( should go on the following line

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:921: * Destroys the
current {@link WebContents}.
Should probably be ContentViewCore instead of WebContents

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1022: *           
the tab.
should be indented 8 here instead (same below)  -- and this can be 100 chars
long so maybe the line wrap isn't needed here.

[Yaron, 2014-05-15 16:53:24]

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:450: return
mNativePage != null ? mNativePage.getView() : (
On 2014/05/12 23:50:57, Ted C wrote:
> I think the ( should go on the following line

Done.

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:921: * Destroys the
current {@link WebContents}.
On 2014/05/12 23:50:57, Ted C wrote:
> Should probably be ContentViewCore instead of WebContents

Had a previous version that was more ambitious but backed off.

https://codereview.chromium.org/275733002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1022: *           
the tab.
On 2014/05/12 23:50:57, Ted C wrote:
> should be indented 8 here instead (same below)  -- and this can be 100 chars
> long so maybe the line wrap isn't needed here.

Done.

[Yaron, 2014-05-15 18:20:24]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-05-15 18:22:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yfriedman@chromium.org/275733002/40001

[commit-bot: I haz the power, 2014-05-15 19:01:00]

Change committed as 270762