chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 275733002: Remove all external references to ContentView from Tab/Shell/etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 275733002: Remove all external references to ContentView from Tab/Shell/etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index 54d2233c8f26b216d2b741bd9fed35dac2532207..a4d74d4240eeaa23ae6088e6d14ac83c46dfff11 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -71,9 +71,11 @@ public class SelectPopupOtherContentViewTest extends ChromeShellTestBase {

public void run() {

long nativeWebContents = ContentViewUtil.createNativeWebContents(false);

WindowAndroid windowAndroid = new ActivityWindowAndroid(getActivity());

- ContentView contentView = ContentView.newInstance(

- getActivity(), nativeWebContents, windowAndroid);

- contentView.getContentViewCore().destroy();

+ ContentViewCore contentViewCore = new ContentViewCore(getActivity());

+ ContentView cv = ContentView.newInstance(getActivity(), contentViewCore);

+ contentViewCore.initialize(cv, cv, nativeWebContents, windowAndroid);

+ contentViewCore.destroy();

}

});