|
|
Chromium Code Reviews
DescriptionAdd PaintCanvas::drawDisplayItemList.
This adds support for drawing nested display lists. Use cases include
SVG images and patterns in Blink.
BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2757313002
Cr-Commit-Position: refs/heads/master@{#458237}
Committed: https://chromium.googlesource.com/chromium/src/+/2da01930e7e357216a8887c0a47b3015ce2060b6
Patch Set 1 #
Total comments: 2
Patch Set 2 : none #Patch Set 3 : none #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== none BUG= ========== to ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add PaintCanvas::drawDisplayItemList. This adds support for drawing nested display lists. Use cases include SVG images and patterns in Blink. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chrishtr@chromium.org changed reviewers: + danakj@chromium.org, enne@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc File cc/paint/skia_paint_canvas.cc (right): https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.... cc/paint/skia_paint_canvas.cc:297: canvas_->drawPicture(recorder.finishRecordingAsPicture(0)); (0) => ()
The CQ bit was checked by chrishtr@chromium.org
https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc File cc/paint/skia_paint_canvas.cc (right): https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.... cc/paint/skia_paint_canvas.cc:297: canvas_->drawPicture(recorder.finishRecordingAsPicture(0)); On 2017/03/20 at 18:10:39, enne wrote: > (0) => () Done.
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2757313002/#ps20001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2757313002/#ps40001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490046143022820,
"parent_rev": "1e092376b3a4416c00e35b097052bd2fe5e118bd", "commit_rev":
"2da01930e7e357216a8887c0a47b3015ce2060b6"}
Message was sent while issue was closed.
Description was changed from ========== Add PaintCanvas::drawDisplayItemList. This adds support for drawing nested display lists. Use cases include SVG images and patterns in Blink. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add PaintCanvas::drawDisplayItemList. This adds support for drawing nested display lists. Use cases include SVG images and patterns in Blink. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757313002 Cr-Commit-Position: refs/heads/master@{#458237} Committed: https://chromium.googlesource.com/chromium/src/+/2da01930e7e357216a8887c0a47b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2da01930e7e357216a8887c0a47b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
