Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2757313002: Add PaintCanvas::drawDisplayItemList (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PaintCanvas::drawDisplayItemList. This adds support for drawing nested display lists. Use cases include SVG images and patterns in Blink. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757313002 Cr-Commit-Position: refs/heads/master@{#458237} Committed: https://chromium.googlesource.com/chromium/src/+/2da01930e7e357216a8887c0a47b3015ce2060b6

Patch Set 1 #

Total comments: 2

Patch Set 2 : none #

Patch Set 3 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M cc/paint/paint_canvas.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M cc/paint/skia_paint_canvas.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M cc/paint/skia_paint_canvas.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
chrishtr
3 years, 9 months ago (2017-03-20 16:50:10 UTC) #6
enne (OOO)
lgtm https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc File cc/paint/skia_paint_canvas.cc (right): https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc#newcode297 cc/paint/skia_paint_canvas.cc:297: canvas_->drawPicture(recorder.finishRecordingAsPicture(0)); (0) => ()
3 years, 9 months ago (2017-03-20 18:10:40 UTC) #9
chrishtr
https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc File cc/paint/skia_paint_canvas.cc (right): https://codereview.chromium.org/2757313002/diff/1/cc/paint/skia_paint_canvas.cc#newcode297 cc/paint/skia_paint_canvas.cc:297: canvas_->drawPicture(recorder.finishRecordingAsPicture(0)); On 2017/03/20 at 18:10:39, enne wrote: > (0) ...
3 years, 9 months ago (2017-03-20 18:15:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757313002/20001
3 years, 9 months ago (2017-03-20 18:16:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/302326)
3 years, 9 months ago (2017-03-20 19:21:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757313002/20001
3 years, 9 months ago (2017-03-20 19:55:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/302440) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-20 19:59:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757313002/40001
3 years, 9 months ago (2017-03-20 21:43:05 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 23:35:58 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2da01930e7e357216a8887c0a47b...

Powered by Google App Engine
This is Rietveld 408576698