Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2757293004: Remove DCHECK when initializing the TabUsageRecorder. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 4 hours ago by Patrick Monette
Modified:
4 days, 1 hour ago
Reviewers:
rkaplow (slow)
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK when initializing the TabUsageRecorder. Instead, the operation is now a no-op. BUG=689765 Review-Url: https://codereview.chromium.org/2757293004 Cr-Commit-Position: refs/heads/master@{#458177} Committed: https://chromium.googlesource.com/chromium/src/+/8c804e2dc91d1deb5401ef5b3f79db97025998dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/tab_usage_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/tab_usage_recorder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (6 generated)
Patrick Monette
PTAL
4 days, 4 hours ago (2017-03-20 17:02:23 UTC) #2
rkaplow (slow)
lgtm
4 days, 4 hours ago (2017-03-20 17:03:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757293004/1
4 days, 3 hours ago (2017-03-20 18:42:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/139986) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 days, 2 hours ago (2017-03-20 19:21:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757293004/1
4 days, 2 hours ago (2017-03-20 19:53:51 UTC) #9
commit-bot: I haz the power
4 days, 1 hour ago (2017-03-20 20:54:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c804e2dc91d1deb5401ef5b3f79...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62