Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|

Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:| (patchset #1 id:1 of https://codereview.chromium.org/2757043002/ )

Reason for revert:
Hi Kurt,
unfortunately this cherry-pick is causing compilation failure on the beta bots, so I'm have to revert it.

Example of failure:
https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1269
The precise compilation error is: https://paste.googleplex.com/5908319097061376

Note: the beta-simulator and beta-device bots are *not* compiling the latest beta, so you can't rely on them to find the compilation error. Right now *only* the official beta builder are failing. I filed a bug about that: crbug/703065


Original issue's description:
> Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
> 
> If a history navigation item occurs and the current NavigationItem is
> transient item, it will get discarded in CRWSessionController's
> |-discardTransientItem|.  This CL updates history navigation logic to
> store copies of the current NavigationItem's information before calling
> any CRWSessionController code that might deallocate it.
> 
> BUG=700319
> 
> Review-Url: https://codereview.chromium.org/2745653007
> Cr-Commit-Position: refs/heads/master@{#456190}
> (cherry picked from commit c0f6017abb9aeb5ae1c8e137b6a3671305298b40)
> 
> Review-Url: https://codereview.chromium.org/2757043002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#279}
> Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed: https://chromium.googlesource.com/chromium/src/+/bda1c548b6b3b69ee60244d49bf986b9e0f4617a

TBR=kkhorimoto@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700319
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2757223002
Cr-Commit-Position: refs/branch-heads/3029@{#305}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/25c92ad9bd75c42d0d0bd0081ed6de019b378eb5

[jif, 2017-03-20 10:30:14]

The CQ bit was checked by jif@chromium.org

[jif, 2017-03-20 10:30:15]

Created Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|

[commit-bot: I haz the power, 2017-03-20 10:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 10:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 10:30:25]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[kkhorimoto, 2017-03-20 17:56:52]

Description was changed from

==========
Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
(patchset #1 id:1 of https://codereview.chromium.org/2757043002/ )

Reason for revert:
Hi Kurt,
unfortunately this cherry-pick is causing compilation failure on the beta bots,
so I'm have to revert it.

Example of failure:
https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1269
The precise compilation error is: https://paste.googleplex.com/5908319097061376

Note: the beta-simulator and beta-device bots are *not* compiling the latest
beta, so you can't rely on them to find the compilation error. Right now *only*
the official beta builder are failing. I filed a bug about that: crbug/703065


Original issue's description:
> Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
> 
> If a history navigation item occurs and the current NavigationItem is
> transient item, it will get discarded in CRWSessionController's
> |-discardTransientItem|.  This CL updates history navigation logic to
> store copies of the current NavigationItem's information before calling
> any CRWSessionController code that might deallocate it.
> 
> BUG=700319
> 
> Review-Url: https://codereview.chromium.org/2745653007
> Cr-Commit-Position: refs/heads/master@{#456190}
> (cherry picked from commit c0f6017abb9aeb5ae1c8e137b6a3671305298b40)
> 
> Review-Url: https://codereview.chromium.org/2757043002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#279}
> Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bda1c548b6b3b69ee60244d49bf9...

TBR=kkhorimoto@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700319
==========

to

==========
Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
(patchset #1 id:1 of https://codereview.chromium.org/2757043002/ )

Reason for revert:
Hi Kurt,
unfortunately this cherry-pick is causing compilation failure on the beta bots,
so I'm have to revert it.

Example of failure:
https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1269
The precise compilation error is: https://paste.googleplex.com/5908319097061376

Note: the beta-simulator and beta-device bots are *not* compiling the latest
beta, so you can't rely on them to find the compilation error. Right now *only*
the official beta builder are failing. I filed a bug about that: crbug/703065


Original issue's description:
> Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
> 
> If a history navigation item occurs and the current NavigationItem is
> transient item, it will get discarded in CRWSessionController's
> |-discardTransientItem|.  This CL updates history navigation logic to
> store copies of the current NavigationItem's information before calling
> any CRWSessionController code that might deallocate it.
> 
> BUG=700319
> 
> Review-Url: https://codereview.chromium.org/2745653007
> Cr-Commit-Position: refs/heads/master@{#456190}
> (cherry picked from commit c0f6017abb9aeb5ae1c8e137b6a3671305298b40)
> 
> Review-Url: https://codereview.chromium.org/2757043002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#279}
> Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bda1c548b6b3b69ee60244d49bf9...

TBR=kkhorimoto@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700319
NOTRY=true
NOPRESUBMIT=true
==========

[kkhorimoto, 2017-03-20 17:56:56]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-03-20 17:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:00:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490032616026050, "parent_rev":
"2dfcff13637fc777c5b581ff7bfb995de6bd5ae3", "commit_rev":
"25c92ad9bd75c42d0d0bd0081ed6de019b378eb5"}

[commit-bot: I haz the power, 2017-03-20 18:01:44]

Description was changed from

==========
Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
(patchset #1 id:1 of https://codereview.chromium.org/2757043002/ )

Reason for revert:
Hi Kurt,
unfortunately this cherry-pick is causing compilation failure on the beta bots,
so I'm have to revert it.

Example of failure:
https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1269
The precise compilation error is: https://paste.googleplex.com/5908319097061376

Note: the beta-simulator and beta-device bots are *not* compiling the latest
beta, so you can't rely on them to find the compilation error. Right now *only*
the official beta builder are failing. I filed a bug about that: crbug/703065


Original issue's description:
> Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
> 
> If a history navigation item occurs and the current NavigationItem is
> transient item, it will get discarded in CRWSessionController's
> |-discardTransientItem|.  This CL updates history navigation logic to
> store copies of the current NavigationItem's information before calling
> any CRWSessionController code that might deallocate it.
> 
> BUG=700319
> 
> Review-Url: https://codereview.chromium.org/2745653007
> Cr-Commit-Position: refs/heads/master@{#456190}
> (cherry picked from commit c0f6017abb9aeb5ae1c8e137b6a3671305298b40)
> 
> Review-Url: https://codereview.chromium.org/2757043002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#279}
> Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bda1c548b6b3b69ee60244d49bf9...

TBR=kkhorimoto@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700319
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Revert of Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
(patchset #1 id:1 of https://codereview.chromium.org/2757043002/ )

Reason for revert:
Hi Kurt,
unfortunately this cherry-pick is causing compilation failure on the beta bots,
so I'm have to revert it.

Example of failure:
https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1269
The precise compilation error is: https://paste.googleplex.com/5908319097061376

Note: the beta-simulator and beta-device bots are *not* compiling the latest
beta, so you can't rely on them to find the compilation error. Right now *only*
the official beta builder are failing. I filed a bug about that: crbug/703065


Original issue's description:
> Fix NavigationItem use-after-free crash in |-goToItemAtIndex:|
> 
> If a history navigation item occurs and the current NavigationItem is
> transient item, it will get discarded in CRWSessionController's
> |-discardTransientItem|.  This CL updates history navigation logic to
> store copies of the current NavigationItem's information before calling
> any CRWSessionController code that might deallocate it.
> 
> BUG=700319
> 
> Review-Url: https://codereview.chromium.org/2745653007
> Cr-Commit-Position: refs/heads/master@{#456190}
> (cherry picked from commit c0f6017abb9aeb5ae1c8e137b6a3671305298b40)
> 
> Review-Url: https://codereview.chromium.org/2757043002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#279}
> Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bda1c548b6b3b69ee60244d49bf9...

TBR=kkhorimoto@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700319
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2757223002
Cr-Commit-Position: refs/branch-heads/3029@{#305}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/25c92ad9bd75c42d0d0bd0081ed6...
==========

[commit-bot: I haz the power, 2017-03-20 18:01:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25c92ad9bd75c42d0d0bd0081ed6...