Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: Source/core/animation/AnimatableRepeatable.h

Issue 27572003: Fix assert failure in AnimatableStrokeDasharrayList::equalTo() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/AnimatableRepeatable.h
diff --git a/Source/core/animation/AnimatableRepeatable.h b/Source/core/animation/AnimatableRepeatable.h
index c0418073d2dc5cb9d848563e5c8217478124d83d..6d1747116666aac96d03d536a293179739755e93 100644
--- a/Source/core/animation/AnimatableRepeatable.h
+++ b/Source/core/animation/AnimatableRepeatable.h
@@ -74,7 +74,8 @@ private:
inline const AnimatableRepeatable* toAnimatableRepeatable(const AnimatableValue* value)
{
- ASSERT_WITH_SECURITY_IMPLICATION(value && value->isRepeatable());
+ // FIXME: Use a better typing system for AnimatableValues that doesn't require ugliness like this to support subclassing.
dstockwell 2013/10/20 23:46:27 Why don't we do that now? (like the toAnimatableR
alancutter (OOO until 2018) 2013/10/20 23:53:12 I still consider that in the same league of ugline
+ ASSERT_WITH_SECURITY_IMPLICATION(value && (value->isRepeatable() || value->isStrokeDasharrayList()));
return static_cast<const AnimatableRepeatable*>(value);
}

Powered by Google App Engine
This is Rietveld 408576698