Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2757143002: The parameter of synthetic setters should inherit 'covariant'. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -16 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 11 chunks +219 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +14 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_driver_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 5 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
scheglov
3 years, 9 months ago (2017-03-19 18:45:54 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-20 13:33:59 UTC) #3
scheglov
3 years, 9 months ago (2017-03-20 17:22:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a94f43334a900905292d8f31123db2a97dcdf490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698