Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 2757143002: The parameter of synthetic setters should inherit 'covariant'. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/format.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index aa8ce252ba64123d7c7c42f46fd934bdb6394b0d..b3c54c02211149048badf8766c014426b6551d53 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -7800,6 +7800,16 @@ class ParameterElementImpl_ofImplicitSetter extends ParameterElementImpl {
}
@override
+ bool get inheritsCovariant {
+ PropertyInducingElement variable = setter.variable;
+ if (variable is FieldElementImpl && variable._unlinkedVariable != null) {
+ return enclosingUnit.resynthesizerContext
+ .inheritsCovariant(variable._unlinkedVariable.inheritsCovariantSlot);
+ }
+ return super.inheritsCovariant;
+ }
+
+ @override
bool get isCovariant {
if (isExplicitlyCovariant || inheritsCovariant) {
return true;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/format.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698