Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2757093002: [Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels (Closed)

Created:
3 years, 9 months ago by jrstanley
Modified:
3 years, 9 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels Fixes an issue where the last network condition prior to going offline was not shared between offline checkboxes (NetworkConditionsSelectors). Due to this change, it is also no longer necessary for each NetworkConditionsSelector to update the state in the networkConditionsChanged() callback and so this has been removed. BUG=702070 Review-Url: https://codereview.chromium.org/2757093002 Cr-Commit-Position: refs/heads/master@{#458699} Committed: https://chromium.googlesource.com/chromium/src/+/8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b

Patch Set 1 #

Patch Set 2 : Rebased (I'm now already in the AUTHORS file) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
jrstanley
PTAL. Apologies in advance if I have selected inappropriate reviewers.
3 years, 9 months ago (2017-03-18 19:22:59 UTC) #6
pfeldman
lgtm
3 years, 9 months ago (2017-03-22 01:20:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757093002/1
3 years, 9 months ago (2017-03-22 01:22:10 UTC) #9
jrstanley
On 2017/03/22 at 01:20:59, pfeldman wrote: > lgtm Thanks pfeldman, and apologies as I think ...
3 years, 9 months ago (2017-03-22 01:44:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757093002/20001
3 years, 9 months ago (2017-03-22 01:45:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 03:48:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757093002/20001
3 years, 9 months ago (2017-03-22 09:30:58 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 09:35:29 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e2177f8dde7e53ab585a1fb09dc...

Powered by Google App Engine
This is Rietveld 408576698