|
|
Created:
3 years, 9 months ago by jrstanley Modified:
3 years, 9 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels
Fixes an issue where the last network condition prior to going offline was not shared between offline checkboxes (NetworkConditionsSelectors).
Due to this change, it is also no longer necessary for each NetworkConditionsSelector to update the state in the networkConditionsChanged() callback and so this has been removed.
BUG=702070
Review-Url: https://codereview.chromium.org/2757093002
Cr-Commit-Position: refs/heads/master@{#458699}
Committed: https://chromium.googlesource.com/chromium/src/+/8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b
Patch Set 1 #Patch Set 2 : Rebased (I'm now already in the AUTHORS file) #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by james@apphaus.co.uk to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
james@apphaus.co.uk changed reviewers: + allada@chromium.org, chenwilliam@chromium.org, pfeldman@chromium.org
PTAL. Apologies in advance if I have selected inappropriate reviewers.
The CQ bit was checked by pfeldman@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by james@apphaus.co.uk
On 2017/03/22 at 01:20:59, pfeldman wrote: > lgtm Thanks pfeldman, and apologies as I think the patch would have failed as I'm in the AUTHORS file now.
The CQ bit was checked by james@apphaus.co.uk
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2757093002/#ps20001 (title: "Rebased (I'm now already in the AUTHORS file)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by james@apphaus.co.uk to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by james@apphaus.co.uk
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490175026706830, "parent_rev": "6caf2deb98f1cf37f5268eed152475016023a95a", "commit_rev": "8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b"}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels Fixes an issue where the last network condition prior to going offline was not shared between offline checkboxes (NetworkConditionsSelectors). Due to this change, it is also no longer necessary for each NetworkConditionsSelector to update the state in the networkConditionsChanged() callback and so this has been removed. BUG=702070 ========== to ========== [Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels Fixes an issue where the last network condition prior to going offline was not shared between offline checkboxes (NetworkConditionsSelectors). Due to this change, it is also no longer necessary for each NetworkConditionsSelector to update the state in the networkConditionsChanged() callback and so this has been removed. BUG=702070 Review-Url: https://codereview.chromium.org/2757093002 Cr-Commit-Position: refs/heads/master@{#458699} Committed: https://chromium.googlesource.com/chromium/src/+/8e2177f8dde7e53ab585a1fb09dc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8e2177f8dde7e53ab585a1fb09dc... |