Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2757083002: feedback: List extensions using the chrome.power API. (Closed)

Created:
3 years, 9 months ago by Daniel Erat
Modified:
3 years, 9 months ago
Reviewers:
afakhry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

feedback: List extensions using the chrome.power API. Make chrome://system include a new "chrome.power extensions" entry listing the IDs and levels ("display" or "system") of extensions that are using the chrome.power API to override power management. BUG=671407 Review-Url: https://codereview.chromium.org/2757083002 Cr-Commit-Position: refs/heads/master@{#459206} Committed: https://chromium.googlesource.com/chromium/src/+/98f6a110bb8ea49b542a02f6c1d8776f80634fca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 4 chunks +21 lines, -0 lines 0 comments Download
M extensions/browser/api/power/power_api.h View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Daniel Erat
3 years, 9 months ago (2017-03-18 00:27:16 UTC) #2
Daniel Erat
mind taking a look? per the bug, this is fine from a privacy perspective.
3 years, 9 months ago (2017-03-23 14:08:26 UTC) #7
afakhry
lgtm
3 years, 9 months ago (2017-03-23 16:07:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757083002/1
3 years, 9 months ago (2017-03-23 16:33:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/415161)
3 years, 9 months ago (2017-03-23 18:04:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757083002/1
3 years, 9 months ago (2017-03-23 19:29:55 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 20:42:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98f6a110bb8ea49b542a02f6c1d8...

Powered by Google App Engine
This is Rietveld 408576698