Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2757063002:
[Chromoting.com] start-host-main crashes (Closed)
Description[Chromoting.com] start-host-main crashes
Looks like net::ChannelIDServiceWorker requires TaskScheduler to be initialized,
but we do not. The top of the stack trace is,
[0316/162617.947344:FATAL:post_task.cc(62)] Check failed:
TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h
BUG=702816
Review-Url: https://codereview.chromium.org/2757063002
Cr-Commit-Position: refs/heads/master@{#458004}
Committed: https://chromium.googlesource.com/chromium/src/+/f38d77604a00b1199e103cfbee7048c10b4a6796
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Chromoting.com] start-host-main crashes Looks like net::ChannelIDServiceWorker requires TaskScheduler to be initialized, but we do not. The top of the stack trace is, [0316/162617.947344:FATAL:post_task.cc(62)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h BUG=702816 ========== to ========== [Chromoting.com] start-host-main crashes Looks like net::ChannelIDServiceWorker requires TaskScheduler to be initialized, but we do not. The top of the stack trace is, [0316/162617.947344:FATAL:post_task.cc(62)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h BUG=702816 ==========
zijiehe@chromium.org changed reviewers: + jamiewalch@chromium.org, sergeyu@chromium.org
lgtm https://codereview.chromium.org/2757063002/diff/1/remoting/host/setup/start_h... File remoting/host/setup/start_host_main.cc (right): https://codereview.chromium.org/2757063002/diff/1/remoting/host/setup/start_h... remoting/host/setup/start_host_main.cc:134: base::TaskScheduler::CreateAndSetSimpleTaskScheduler(5); Add a const for 5, like here: https://codesearch.chromium.org/chromium/src/remoting/host/remoting_me2me_hos... That makes it clear what this value means.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2757063002/diff/1/remoting/host/setup/start_h... File remoting/host/setup/start_host_main.cc (right): https://codereview.chromium.org/2757063002/diff/1/remoting/host/setup/start_h... remoting/host/setup/start_host_main.cc:134: base::TaskScheduler::CreateAndSetSimpleTaskScheduler(5); On 2017/03/17 23:27:48, Sergey Ulanov wrote: > Add a const for 5, like here: > https://codesearch.chromium.org/chromium/src/remoting/host/remoting_me2me_hos... > That makes it clear what this value means. Done.
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.chromium.org/2757063002/#ps20001 (title: "Resolve review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489959905382520,
"parent_rev": "bded1e56dae37cf9a30684511f14a22952616b32", "commit_rev":
"f38d77604a00b1199e103cfbee7048c10b4a6796"}
Message was sent while issue was closed.
Description was changed from ========== [Chromoting.com] start-host-main crashes Looks like net::ChannelIDServiceWorker requires TaskScheduler to be initialized, but we do not. The top of the stack trace is, [0316/162617.947344:FATAL:post_task.cc(62)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h BUG=702816 ========== to ========== [Chromoting.com] start-host-main crashes Looks like net::ChannelIDServiceWorker requires TaskScheduler to be initialized, but we do not. The top of the stack trace is, [0316/162617.947344:FATAL:post_task.cc(62)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h BUG=702816 Review-Url: https://codereview.chromium.org/2757063002 Cr-Commit-Position: refs/heads/master@{#458004} Committed: https://chromium.googlesource.com/chromium/src/+/f38d77604a00b1199e103cfbee70... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f38d77604a00b1199e103cfbee70... |
