Make GN Android build link executables

tools/gn/target.cc

Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index b6845d03de6698cd96ccc07f2f9e4ac3678d2a31..b8be9a45311fb9982072126e2d28bda3ee0b809c 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -211,7 +211,11 @@ void Target::PullRecursiveHardDeps() {
     const Target* dep = deps_[dep_i].ptr;
     if (dep->hard_dep())
       recursive_hard_deps_.insert(dep);
-    recursive_hard_deps_.insert(dep->recursive_hard_deps().begin(),
-                                dep->recursive_hard_deps().end());
+
+    // Android STL doesn't like insert(begin, end) so do it manually.

[awong, 2014/05/12 19:23:02]

Can you put a TODO with a bug somewhere on this? I'm hoping we can transition
away from STLPort once we fix NDK for libcxx (which I'm hoping to do in 2 weeks)
which means there's a path to remove crap like this.

[brettw, 2014/05/12 21:00:08]

I put a todo in there but did not file a bug. I don't think the bug will help
anybody and will likely be lost even when we fix the issue. I can if you really
really want me to.

[awong, 2014/05/12 21:34:23]

sgtm

+    for (std::set<const Target*>::const_iterator cur =
+             dep->recursive_hard_deps().begin();
+         cur != dep->recursive_hard_deps().end(); ++cur)
+      recursive_hard_deps_.insert(*cur);
   }
 }