Make GN Android build link executables

tools/gn/target.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/target.h"
 
 #include "base/bind.h"
 #include "tools/gn/config_values_extractors.h"
 #include "tools/gn/scheduler.h"
 
@@ skipping 193 matching lines @@
         from_target->direct_dependent_configs().begin(),
         from_target->direct_dependent_configs().end());
   }
 }
 
 void Target::PullRecursiveHardDeps() {
   for (size_t dep_i = 0; dep_i < deps_.size(); dep_i++) {
     const Target* dep = deps_[dep_i].ptr;
     if (dep->hard_dep())
       recursive_hard_deps_.insert(dep);
-    recursive_hard_deps_.insert(dep->recursive_hard_deps().begin(),
-                                dep->recursive_hard_deps().end());
+
+    // Android STL doesn't like insert(begin, end) so do it manually.

[awong, 2014/05/12 19:23:02]

Can you put a TODO with a bug somewhere on this? I'm hoping we can transition
away from STLPort once we fix NDK for libcxx (which I'm hoping to do in 2 weeks)
which means there's a path to remove crap like this.

[brettw, 2014/05/12 21:00:08]

I put a todo in there but did not file a bug. I don't think the bug will help
anybody and will likely be lost even when we fix the issue. I can if you really
really want me to.

[awong, 2014/05/12 21:34:23]

sgtm

+    for (std::set<const Target*>::const_iterator cur =
+             dep->recursive_hard_deps().begin();
+         cur != dep->recursive_hard_deps().end(); ++cur)
+      recursive_hard_deps_.insert(*cur);
   }
 }