Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2757003002: Untyped intranet URL check should examine the start and end of a redirect chain. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Peter Kasting OOO thru Aug 22
Modified:
5 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Untyped intranet URL check should examine the start and end of a redirect chain. Previously, we only looked at the start of the chain, but it's also important to look at the end, since it's possible for a non-intranet URL to redirect to an intranet URL, and we need to mark that as a "known host" as well. This prevents subsequent edits to that intranet URL from unexpectedly searching rather than navigating. BUG=701091 TEST=none Review-Url: https://codereview.chromium.org/2757003002 Cr-Commit-Position: refs/heads/master@{#458184} Committed: https://chromium.googlesource.com/chromium/src/+/3b149b2d2e71280dc70df934427df29e9ee25169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -31 lines) Patch
M components/history/core/browser/history_backend.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/history/core/browser/history_backend.cc View 2 chunks +20 lines, -15 lines 0 comments Download
M components/history/core/browser/history_service_unittest.cc View 4 chunks +47 lines, -15 lines 0 comments Download
Trybot results:  cast_shell_linux   ios-simulator-xcode-clang   win_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   linux_chromium_chromeos_rel_ng   chromium_presubmit   ios-device   android_n5x_swarming_rel   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_tsan_rel_ng   chromeos_daisy_chromium_compile_only_ng   ios-device-xcode-clang   mac_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   ios-simulator   win_clang   android_compile_dbg   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   android_clang_dbg_recipe   android_arm64_dbg_recipe   android_cronet   linux_android_rel_ng   cast_shell_android   linux_chromium_rel_ng   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_x64_rel_ng   win_clang   linux_android_rel_ng   cast_shell_linux   linux_chromium_chromeos_rel_ng   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   android_cronet   win_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_tsan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_rel_ng   cast_shell_android   linux_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-device-xcode-clang   android_n5x_swarming_rel   mac_chromium_compile_dbg_ng   android_compile_dbg   win_chromium_compile_dbg_ng   ios-device   ios-simulator   ios-simulator-xcode-clang   android_arm64_dbg_recipe   chromium_presubmit 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
Peter Kasting OOO thru Aug 22
5 months ago (2017-03-17 20:27:40 UTC) #2
sdefresne
lgtm
5 months ago (2017-03-20 14:11:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757003002/1
5 months ago (2017-03-20 20:07:39 UTC) #9
commit-bot: I haz the power
5 months ago (2017-03-20 21:12:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b149b2d2e71280dc70df934427d...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b