Componentize safe_browsing: move renderer/ reporting part for WebView.

Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer safe browsing reporting code to component
in order to make it available for Android WebView.

BUG=700351, 688629
Review-Url: https://codereview.chromium.org/2756933003
Cr-Commit-Position: refs/heads/master@{#458286}
Committed: https://chromium.googlesource.com/chromium/src/+/c881a5d65d8e3276d186c57f9a91e378fa0141a4

[timvolodine, 2017-03-17 19:19:17]

Description was changed from

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer reporting code to component in order to
make it available for WebView.

BUG=700351
==========

to

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer reporting code to component in order to
make it available for WebView.

BUG=700351,688629
==========

[timvolodine, 2017-03-17 19:20:23]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-03-17 19:34:22]

strongly reduced version of https://codereview.chromium.org/2667343006/

[timvolodine, 2017-03-17 19:35:08]

timvolodine@chromium.org changed reviewers:
+ jialiul@chromium.org

[timvolodine, 2017-03-17 19:35:09]

+jialiul@: another attempt PTAL )

[timvolodine, 2017-03-17 19:36:00]

Description was changed from

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer reporting code to component in order to
make it available for WebView.

BUG=700351,688629
==========

to

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer reporting code to component in order to
make it available for Android WebView.

BUG=700351,688629
==========

[commit-bot: I haz the power, 2017-03-17 20:27:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:27:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[timvolodine, 2017-03-17 21:10:40]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 21:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 21:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:16:28]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2017-03-17 21:18:52]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 21:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-03-17 21:27:42]

+cc:nparker@

[vakh (use Gerrit instead), 2017-03-17 22:04:36]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2017-03-17 22:04:37]

lgtm

Please let jialiul@ or nparker@ also lgtm before submitting.

[Jialiu Lin, 2017-03-17 22:42:06]

LGTM Thank you!

[commit-bot: I haz the power, 2017-03-17 23:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:00:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nathan Parker, 2017-03-18 00:15:11]

nparker@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2017-03-18 00:15:12]

nparker@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2017-03-18 00:15:12]

Cool, thanks Tim.

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
File components/safe_browsing/renderer/BUILD.gn (right):

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
components/safe_browsing/renderer/BUILD.gn:8: if (safe_browsing_mode != 0) {
note: I _think_ this ==0 only for iOS, and I'm not sure if iOS would even pull
in this code. fine to leave it for now.

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
File components/safe_browsing/renderer/OWNERS (right):

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
components/safe_browsing/renderer/OWNERS:1: mattm@chromium.org
You can drop this file, since these are a subset of ../OWNERS.

[Nathan Parker, 2017-03-18 00:15:12]

Cool, thanks Tim.

[Nathan Parker, 2017-03-18 00:16:01]

whoa, focus-grabbing gone awry.  Ok, trying again.

LGTM and +lpz for awareness

[timvolodine, 2017-03-20 12:15:50]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 12:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-03-20 12:20:33]

Description was changed from

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer reporting code to component in order to
make it available for Android WebView.

BUG=700351,688629
==========

to

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer safe browsing reporting code to component
in order to make it available for Android WebView.

BUG=700351,688629
==========

[timvolodine, 2017-03-20 12:44:59]

The CQ bit was unchecked by timvolodine@chromium.org

[timvolodine, 2017-03-20 12:53:38]

Thanks all for the reviews and the comments!

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
File components/safe_browsing/renderer/BUILD.gn (right):

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
components/safe_browsing/renderer/BUILD.gn:8: if (safe_browsing_mode != 0) {
On 2017/03/18 00:15:12, Nathan Parker wrote:
> note: I _think_ this ==0 only for iOS, and I'm not sure if iOS would even pull
> in this code. fine to leave it for now.

Acknowledged.

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
File components/safe_browsing/renderer/OWNERS (right):

https://codereview.chromium.org/2756933003/diff/40001/components/safe_browsin...
components/safe_browsing/renderer/OWNERS:1: mattm@chromium.org
On 2017/03/18 00:15:12, Nathan Parker wrote:
> You can drop this file, since these are a subset of ../OWNERS.

Indeed, done.

[timvolodine, 2017-03-20 12:53:46]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2017-03-20 12:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, vakh@chromium.org, jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2756933003/#ps60001
(title: "fix comments")

[commit-bot: I haz the power, 2017-03-20 12:53:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:03:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2017-03-20 13:08:17]

timvolodine@chromium.org changed reviewers:
+ jam@chromium.org

[timvolodine, 2017-03-20 13:08:18]

+jam@: for overall RS

[jam, 2017-03-20 17:14:06]

lgtm

[timvolodine, 2017-03-21 01:52:44]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 02:46:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490061164746970,
"parent_rev": "d194e61817b42109d34cfdc841f4269061ac1ca9", "commit_rev":
"c881a5d65d8e3276d186c57f9a91e378fa0141a4"}

[commit-bot: I haz the power, 2017-03-21 02:47:18]

Description was changed from

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer safe browsing reporting code to component
in order to make it available for Android WebView.

BUG=700351,688629
==========

to

==========
Componentize safe_browsing: move renderer/ reporting part for WebView.

Moves the chrome/renderer safe browsing reporting code to component
in order to make it available for Android WebView.

BUG=700351,688629

Review-Url: https://codereview.chromium.org/2756933003
Cr-Commit-Position: refs/heads/master@{#458286}
Committed:
https://chromium.googlesource.com/chromium/src/+/c881a5d65d8e3276d186c57f9a91...
==========

[commit-bot: I haz the power, 2017-03-21 02:47:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c881a5d65d8e3276d186c57f9a91...