Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2756933002: App Banner: BeforeInstallPrompt.platforms should use a FrozenArary<> (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
Reviewers:
dominickn
CC:
blink-reviews, chromium-reviews, dominickn+watch_chromium.org, haraken, mlamouri+watch-blink_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App Banner: BeforeInstallPrompt.platforms should use a FrozenArary<> BUG=702580 R=dominickn@chromium.org Review-Url: https://codereview.chromium.org/2756933002 Cr-Commit-Position: refs/heads/master@{#458049} Committed: https://chromium.googlesource.com/chromium/src/+/b41da6057cbf6fe719a7105881a195dcb49e297d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 9 months ago (2017-03-17 16:22:32 UTC) #5
dominickn
lgtm, thanks!
3 years, 9 months ago (2017-03-19 23:03:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756933002/1
3 years, 9 months ago (2017-03-20 11:11:13 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 13:30:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b41da6057cbf6fe719a7105881a1...

Powered by Google App Engine
This is Rietveld 408576698