Chromium Code Reviews

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)
Patch Set: mfomitchev responses, rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
index c04cf5d03a4506bf573ec02dd568f41f7169c695..7cd0e0cc99c5a647a546a18f08f9a3da247d1bf7 100644
--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
@@ -298,13 +298,17 @@ const int kMaxCharacters = 4000;
// Forward the event to the renderer.
// TODO(rohitrao): Should this call -[BaseView keyEvent:]? Is there code in
// that function that we want to keep or avoid? Calling
- // |ForwardKeyboardEvent()| directly ignores edit commands, which breaks
- // cmd-up/down if we ever decide to include |moveToBeginningOfDocument:| in
- // the list above.
+ // |ForwardKeyboardEventWithLatencyInfo()| directly ignores edit commands,
+ // which breaks cmd-up/down if we ever decide to include
+ // |moveToBeginningOfDocument:| in the list above.
content::RenderViewHost* render_view_host =
web_contents->GetRenderViewHost();
- render_view_host->GetWidget()->ForwardKeyboardEvent(
- NativeWebKeyboardEvent(event));
+
+ LatencyInfo latency;
+ latency->AddLatencyNumber(INPUT_EVENT_LATENCY_UI_COMPONENT, 0, 0);
+
+ render_view_host->GetWidget()->ForwardKeyboardEventWithLatencyInfo(
+ NativeWebKeyboardEvent(event), latency);
return YES;
}

Powered by Google App Engine