chrome/browser/password_manager/password_generation_interactive_uitest.cc - Issue 2756893002: Add Keyboard Latency UMA Metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_generation_interactive_uitest.cc

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)

Patch Set: mfomitchev responses, rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/accessibility/event_handler_common.cc ('k') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('j') | ui/events/event.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_generation_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_generation_interactive_uitest.cc b/chrome/browser/password_manager/password_generation_interactive_uitest.cc

index d0fd8ff872ca502ba9832854bfd0320f5341c9ad..b3bd6e039bae5e65bd2715ffa2355fc0143c9ec4 100644

--- a/chrome/browser/password_manager/password_generation_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_generation_interactive_uitest.cc

@@ -122,7 +122,8 @@ class PasswordGenerationInteractiveTest :

blink::WebInputEvent::kNoModifiers,

blink::WebInputEvent::kTimeStampForTesting);

event.windows_key_code = key;

- RenderViewHost()->GetWidget()->ForwardKeyboardEvent(event);

+ RenderViewHost()->GetWidget()->ForwardKeyboardEventWithLatencyInfo(

+ event, ui::LatencyInfo());

}

bool GenerationPopupShowing() {