[sql] Tests for updates to mmap state.

[sql] Tests for updates to mmap state.

Histograms indicate a bit more EVENT_MMAP_STATUS_FAILURE_UPDATE and
EVENT_MMAP_META_FAILURE_UPDATE than I was hoping for, and I realized
that that code was untested.  Add some tests for that case.
Unfortunately for the histograms, the untested code appears to work.

BUG=652359
Review-Url: https://codereview.chromium.org/2756843003
Cr-Commit-Position: refs/heads/master@{#458007}
Committed: https://chromium.googlesource.com/chromium/src/+/a7b07acd99ebfd40b319dfd49103081a8c538ec4

[Scott Hess - ex-Googler, 2017-03-17 19:11:26]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2017-03-17 19:15:35]

shess@chromium.org changed reviewers:
+ pavely@chromium.org

[Scott Hess - ex-Googler, 2017-03-17 19:15:36]

Picking from reviewers from:
   https://codereview.chromium.org/2397753005
you get the token because sync was the primary reason for writing the new code. 
Thanks!

[I'd give it to Michael, but he's just back from a leave and I'd like to keep
the load spread.]

[commit-bot: I haz the power, 2017-03-17 19:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:29:26]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-03-17 23:21:35]

lgtm

https://codereview.chromium.org/2756843003/diff/1/sql/connection_unittest.cc
File sql/connection_unittest.cc (right):

https://codereview.chromium.org/2756843003/diff/1/sql/connection_unittest.cc#...
sql/connection_unittest.cc:1607: ASSERT_TRUE(db().Execute("CREATE VIEW
MmapStatus AS SELECT 1"));
nit: When Connection::SetMmapAltStatus creates view it sets column name to
"value" as well. It is not an issue as long as it reads value with "select *".
Might cause test failures if query changes to "select value from MmapStatus".

[Scott Hess - ex-Googler, 2017-03-19 23:45:31]

CREATE VIEW should match the one in connection.cc.

[Scott Hess - ex-Googler, 2017-03-19 23:47:15]

Thanks!

https://codereview.chromium.org/2756843003/diff/1/sql/connection_unittest.cc
File sql/connection_unittest.cc (right):

https://codereview.chromium.org/2756843003/diff/1/sql/connection_unittest.cc#...
sql/connection_unittest.cc:1607: ASSERT_TRUE(db().Execute("CREATE VIEW
MmapStatus AS SELECT 1"));
On 2017/03/17 23:21:35, pavely wrote:
> nit: When Connection::SetMmapAltStatus creates view it sets column name to
> "value" as well. It is not an issue as long as it reads value with "select *".
> Might cause test failures if query changes to "select value from MmapStatus".

Good point.  I'm changing the variant a few lines down, too (I think that's
where this one came from, as I'm far too lazy to write new code for something
like this).

[Scott Hess - ex-Googler, 2017-03-19 23:47:19]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2017-03-19 23:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2756843003/#ps20001
(title: "CREATE VIEW should match the one in connection.cc.")

[commit-bot: I haz the power, 2017-03-19 23:47:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 23:59:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489967239697530,
"parent_rev": "8f1b6debc47bc4c5e528fe56a7941c36b04c7f1a", "commit_rev":
"a7b07acd99ebfd40b319dfd49103081a8c538ec4"}

[commit-bot: I haz the power, 2017-03-20 00:00:24]

Description was changed from

==========
[sql] Tests for updates to mmap state.

Histograms indicate a bit more EVENT_MMAP_STATUS_FAILURE_UPDATE and
EVENT_MMAP_META_FAILURE_UPDATE than I was hoping for, and I realized
that that code was untested.  Add some tests for that case.
Unfortunately for the histograms, the untested code appears to work.

BUG=652359
==========

to

==========
[sql] Tests for updates to mmap state.

Histograms indicate a bit more EVENT_MMAP_STATUS_FAILURE_UPDATE and
EVENT_MMAP_META_FAILURE_UPDATE than I was hoping for, and I realized
that that code was untested.  Add some tests for that case.
Unfortunately for the histograms, the untested code appears to work.

BUG=652359

Review-Url: https://codereview.chromium.org/2756843003
Cr-Commit-Position: refs/heads/master@{#458007}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7b07acd99ebfd40b319dfd49103...
==========

[commit-bot: I haz the power, 2017-03-20 00:00:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7b07acd99ebfd40b319dfd49103...