Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2756803002: MD Settings: Fix search bug caused by accidental removal of subpage trigger IDs. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
dschuyler, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, hcarmona
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix search bug caused by accidental removal of subpage trigger IDs. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2756803002 Cr-Commit-Position: refs/heads/master@{#457654} Committed: https://chromium.googlesource.com/chromium/src/+/0f0c1893bd9b05b51a6e5df58495137fb1c1938b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dpapad
The IDs were removed at https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html. I'll try to add some automated tests for this ...
3 years, 9 months ago (2017-03-17 00:55:24 UTC) #5
Dan Beam
damn, lgtm
3 years, 9 months ago (2017-03-17 01:14:53 UTC) #7
dschuyler
lgtm
3 years, 9 months ago (2017-03-17 01:19:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756803002/1
3 years, 9 months ago (2017-03-17 01:33:09 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 01:56:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f0c1893bd9b05b51a6e5df58495...

Powered by Google App Engine
This is Rietveld 408576698