Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2756753002: Reland of "Cleaned up old navigation code that did not use pending navigation item." (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Cleaned up old navigation code that did not use pending navigation item." Also removed PendingIndexNavigationDisabled experimental setting. BUG=692331, 701717 TEST=Back forward navigation works correctly. Original Review-Url: https://codereview.chromium.org/2751793002 Review-Url: https://codereview.chromium.org/2756753002 Cr-Commit-Position: refs/heads/master@{#457765} Committed: https://chromium.googlesource.com/chromium/src/+/3e87288e88257beea1727e67da8b69a77b7715a1

Patch Set 1 : Original CL #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -305 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +0 lines, -10 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/web/visible_url_egtest.mm View 11 chunks +0 lines, -42 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +1 line, -8 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 8 chunks +47 lines, -160 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 2 chunks +0 lines, -68 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Eugene But (OOO till 7-30)
Relanding reverted CL
3 years, 9 months ago (2017-03-16 20:53:27 UTC) #2
kkhorimoto
lgtm, but can you clean up the CL description and mention that it's a reland ...
3 years, 9 months ago (2017-03-17 01:22:16 UTC) #3
Eugene But (OOO till 7-30)
On 2017/03/17 01:22:16, kkhorimoto_ wrote: > lgtm, but can you clean up the CL description ...
3 years, 9 months ago (2017-03-17 14:24:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756753002/20001
3 years, 9 months ago (2017-03-17 14:24:54 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 14:48:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e87288e88257beea1727e67da8b...

Powered by Google App Engine
This is Rietveld 408576698