Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2756733005: [Merge M58] Fix refresh token is not available after Chrome restart on crash. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] Fix refresh token is not available after Chrome restart on crash. In case Chrome crashed and restarted, refresh token was not reloaded. This caused several problems, including random user image profile and impossibility to opt in ARC. TEST=Manually simulated crash. On Chrome restart profile image is correct and ARC can be opted in. Also logs show that token is loaded correctly. BUG=701866 TBR=xiyuan@chromium.org,isherman@chromium.org,msarda@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2752873002 Cr-Commit-Position: refs/heads/master@{#457619} (cherry picked from commit f0e2fb482636b0c1aed01f2d672ec5619bff9eb9) Review-Url: https://codereview.chromium.org/2756733005 Cr-Commit-Position: refs/branch-heads/3029@{#269} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e9756a1c5e5aa3819bcec390961a8af429b8ad66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
khmel
3 years, 9 months ago (2017-03-17 17:17:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756733005/1
3 years, 9 months ago (2017-03-17 17:49:07 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-17 17:49:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756733005/1
3 years, 9 months ago (2017-03-17 17:51:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:53:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9756a1c5e5aa3819bcec390961a...

Powered by Google App Engine
This is Rietveld 408576698