Delete SecCertificate equality hacks for old macOS versions

Delete SecCertificate equality hacks for old macOS versions

BUG=none

Review-Url: https://codereview.chromium.org/2756733003
Cr-Commit-Position: refs/heads/master@{#457761}
Committed: https://chromium.googlesource.com/chromium/src/+/2291f94252fe3921fee1a5039708553e14141b68

[mattm, 2017-03-17 01:15:41]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[mattm, 2017-03-17 01:15:53]

mattm@chromium.org changed reviewers:
+ rsleevi@chromium.org

[mattm, 2017-03-17 01:15:53]

https://codereview.chromium.org/2756733003/diff/1/net/cert/x509_certificate_m...
File net/cert/x509_certificate_mac.cc (left):

https://codereview.chromium.org/2756733003/diff/1/net/cert/x509_certificate_m...
net/cert/x509_certificate_mac.cc:289: if (a == b)
was doing this check here before calling CFEqual an optimization?

[commit-bot: I haz the power, 2017-03-17 01:16:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 01:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:45:40]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2017-03-17 14:13:58]

lgtm

https://codereview.chromium.org/2756733003/diff/1/net/cert/x509_certificate_m...
File net/cert/x509_certificate_mac.cc (left):

https://codereview.chromium.org/2756733003/diff/1/net/cert/x509_certificate_m...
net/cert/x509_certificate_mac.cc:289: if (a == b)
On 2017/03/17 01:15:53, mattm wrote:
> was doing this check here before calling CFEqual an optimization?

Yup

[Ryan Sleevi, 2017-03-17 14:22:08]

Description was changed from

==========
delete SecCertificate equality hacks for old macOS versions

BUG=none
==========

to

==========
Delete SecCertificate equality hacks for old macOS versions

BUG=none
==========

[Ryan Sleevi, 2017-03-17 14:22:13]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:22:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:27:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489760533871580, "parent_rev":
"0a0546417f0a60bb9822b5744de970adce5302fd", "commit_rev":
"2291f94252fe3921fee1a5039708553e14141b68"}

[commit-bot: I haz the power, 2017-03-17 14:28:18]

Description was changed from

==========
Delete SecCertificate equality hacks for old macOS versions

BUG=none
==========

to

==========
Delete SecCertificate equality hacks for old macOS versions

BUG=none

Review-Url: https://codereview.chromium.org/2756733003
Cr-Commit-Position: refs/heads/master@{#457761}
Committed:
https://chromium.googlesource.com/chromium/src/+/2291f94252fe3921fee1a5039708...
==========

[commit-bot: I haz the power, 2017-03-17 14:28:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2291f94252fe3921fee1a5039708...