Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2756733002: s390: Unify Visit(Word/Float)(32/64)(Unary/Bin)Op (Closed)

Created:
3 years, 9 months ago by john.yan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Unify Visit(Word/Float)(32/64)(Unary/Bin)Op R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com Review-Url: https://codereview.chromium.org/2756733002 Cr-Commit-Position: refs/heads/master@{#43876} Committed: https://chromium.googlesource.com/v8/v8/+/0e893511b36cf2eba6b1cb26b5ef6caac15554ab

Patch Set 1 #

Patch Set 2 : remove unnecessary check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -554 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 15 chunks +33 lines, -11 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 17 chunks +418 lines, -542 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
john.yan
ptal
3 years, 9 months ago (2017-03-16 18:21:05 UTC) #1
michael_dawson
On 2017/03/16 18:21:05, john.yan wrote: > ptal lgtm
3 years, 9 months ago (2017-03-16 18:48:53 UTC) #4
michael_dawson
On 2017/03/16 18:21:05, john.yan wrote: > ptal lgtm
3 years, 9 months ago (2017-03-16 18:48:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756733002/20001
3 years, 9 months ago (2017-03-16 18:49:58 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 18:55:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0e893511b36cf2eba6b1cb26b5ef6caac15...

Powered by Google App Engine
This is Rietveld 408576698